hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-1135: Move hive language manual from wiki to SVN
Date Mon, 14 Jun 2010 22:26:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/178/#review217
-----------------------------------------------------------


Looks good overall.

A couple suggestions:
* Stash this stuff under docs/ instead of creating another top level directory (xdocs/)
* Manage the jdom dependency with Ivy.
* Limit the initial import to the convents of the Hive Language Manual. I think some things
should actually stay on the wiki, but the language manual is definitely one of those things
that we want to have in VCS.


trunk/build.xml
<http://review.hbase.org/r/178/#comment982>

    I think it would be good to use the full name ("anakia") instead of abbreviating it as
"an".



trunk/build.xml
<http://review.hbase.org/r/178/#comment985>

    Please add a description so that this shows up in the output of 'ant -p'



trunk/build.xml
<http://review.hbase.org/r/178/#comment986>

    Can we rename this "check-for-anakia" and remove the "prepare-error" target, i.e. something
similar to the way the checkstyle check is currently done?



trunk/hwi/web/set_processor.jsp
<http://review.hbase.org/r/178/#comment987>

    Did you mean to include this in the patch?



trunk/xdocs/docs/glossary.xml
<http://review.hbase.org/r/178/#comment988>

    This email address looks bogus. Perhaps this should be hive-dev@hadoop.apache.org? Or
else leave it out entirely?
    
    Is the author property something that we can define in velocity.properties?



trunk/xdocs/stylesheets/project.xml
<http://review.hbase.org/r/178/#comment993>

    Let's try to stick with consistent indentation (2 characters).



trunk/xdocs/stylesheets/site.vsl
<http://review.hbase.org/r/178/#comment995>

    ASF header repeated twice.


- Carl


On 2010-06-14 14:43:29, Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/178/
> -----------------------------------------------------------
> 
> (Updated 2010-06-14 14:43:29)
> 
> 
> Review request for Hive Developers.
> 
> 
> Summary
> -------
> 
> Submitted on behalf of Ed Capriolo.
> 
> 
> This addresses bug hive-1135.
>     http://issues.apache.org/jira/browse/hive-1135
> 
> 
> Diffs
> -----
> 
>   trunk/build.xml 953531 
>   trunk/hwi/web/set_processor.jsp 953531 
>   trunk/xdocs/docs/glossary.xml PRE-CREATION 
>   trunk/xdocs/docs/index.xml PRE-CREATION 
>   trunk/xdocs/docs/language_manual/data-manipulation-statements.xml PRE-CREATION 
>   trunk/xdocs/docs/language_manual/working_with_bucketed_tables.xml PRE-CREATION 
>   trunk/xdocs/docs/user/hwi.xml PRE-CREATION 
>   trunk/xdocs/site.css PRE-CREATION 
>   trunk/xdocs/stylesheets/project.xml PRE-CREATION 
>   trunk/xdocs/stylesheets/site.vsl PRE-CREATION 
>   trunk/xdocs/velocity.properties PRE-CREATION 
> 
> Diff: http://review.hbase.org/r/178/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carl
> 
>


Mime
View raw message