hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1229) replace dependencies on HBase deprecated API
Date Mon, 28 Jun 2010 21:13:07 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883301#action_12883301
] 

HBase Review Board commented on HIVE-1229:
------------------------------------------

Message from: "John Sichi" <jsichi@facebook.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/239/#review286
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hadoop/hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java
<http://review.hbase.org/r/239/#comment1286>

    Can we avoid the per-row call to toBytes here by keeping around the bytes instead of the
string for the column name?



http://svn.apache.org/repos/asf/hadoop/hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSplit.java
<http://review.hbase.org/r/239/#comment1287>

    I'm not sure we can get rid of the column mapping info from the split like this.  This
may be the reason why hbase_joins.q is failing.
    



http://svn.apache.org/repos/asf/hadoop/hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableOutputFormat.java
<http://review.hbase.org/r/239/#comment1285>

    Isn't the "implements OutputFormat" redundant since TableOutputFormat also implements
OutputFormat?



http://svn.apache.org/repos/asf/hadoop/hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseCellMap.java
<http://review.hbase.org/r/239/#comment1284>

    Can we move this (and the Bytes.toBytes(columnFamily) below) to init?  That way we don't
have to pay the cost for every row.
    
    Also, if it doesn't end in colon, isn't something wrong?
    



http://svn.apache.org/repos/asf/hadoop/hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java
<http://review.hbase.org/r/239/#comment1283>

    Normally I would agree that it is good to use List rather than ArrayList, but not in this
case since it forces us to cast later on due to LazyStruct's explicit usage of ArrayList.
 So I think we should suppress the checkstyle warning in this case.
    


- John





> replace dependencies on HBase deprecated API
> --------------------------------------------
>
>                 Key: HIVE-1229
>                 URL: https://issues.apache.org/jira/browse/HIVE-1229
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: HBase Handler
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Basab Maulik
>         Attachments: HIVE-1229.1.patch, HIVE-1229.2.patch
>
>
> Some of these dependencies are on the old Hadoop mapred packages; others are HBase-specific.
 The former have to wait until the rest of Hive moves over to the new Hadoop mapreduce package,
but the HBase-specific ones don't have to wait.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message