hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Thusoo (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1359) Unit test should be shim-aware
Date Fri, 28 May 2010 14:06:38 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872990#action_12872990

Ashish Thusoo commented on HIVE-1359:

+1 to all the great suggestions in this discussion...

I have one more thing to add. Would it be more maintainable to associate the include/exclude
information with the test as the key as opposed to the version being the key i.e.

instead of

  include - test1.q, test2.q ..
  exclude - test3.q

  include - test3.q
  exclude - test1.q

we do

  exclude - < 0.17.0

  include - >= 0.17.0

or something on that line... this may make adding tests to versions fairly easy.

> Unit test should be shim-aware
> ------------------------------
>                 Key: HIVE-1359
>                 URL: https://issues.apache.org/jira/browse/HIVE-1359
>             Project: Hadoop Hive
>          Issue Type: New Feature
>            Reporter: Ning Zhang
>            Assignee: Ning Zhang
>         Attachments: unit_tests.txt
> Some features in Hive only works for certain Hadoop versions through shim. However the
unit test structure is not shim-aware in that there is only one set of queries and expected
outputs for all Hadoop versions. This may not be sufficient when we will have different output
for different Hadoop versions. One example is CombineHiveInputFormat wich is only available
from Hadoop 0.20. The plan using CombineHiveInputFormat and HiveInputFormat may be different.
Another example is archival partitions (HAR) which is also only available from 0.20. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message