hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ning Zhang <nzh...@facebook.com>
Subject Re: [jira] Commented: (HIVE-1123) Checkstyle fixes
Date Mon, 08 Feb 2010 07:41:42 GMT
I don't know whether checkstyle can check such a case. So we probably don't include it in the
automatically checking, but just keep in mind to avoid long statements.

+1 from me.

On Feb 7, 2010, at 10:53 PM, Zheng Shao (JIRA) wrote:

> 
>    [ https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830852#action_12830852
] 
> 
> Zheng Shao commented on HIVE-1123:
> ----------------------------------
> 
> I prefer the second format too. Ning, does checkstyle count it as an error or not?
> 
> If there are no -1, I will commit these patches on Monday 2/8/2010 afternoon.
> 
> 
>> Checkstyle fixes
>> ----------------
>> 
>>                Key: HIVE-1123
>>                URL: https://issues.apache.org/jira/browse/HIVE-1123
>>            Project: Hadoop Hive
>>         Issue Type: Task
>>           Reporter: Carl Steinbach
>>           Assignee: Carl Steinbach
>>        Attachments: HIVE-1123.checkstyle.patch, HIVE-1123.cli.2.patch, HIVE-1123.cli.patch,
HIVE-1123.common.2.patch, HIVE-1123.common.patch, HIVE-1123.contrib.2.patch, HIVE-1123.contrib.patch,
HIVE-1123.hwi.2.patch, HIVE-1123.hwi.patch, HIVE-1123.jdbc.2.patch, HIVE-1123.jdbc.patch,
HIVE-1123.metastore.2.patch, HIVE-1123.metastore.patch, HIVE-1123.ql.2.patch, HIVE-1123.ql.patch,
HIVE-1123.serde.2.patch, HIVE-1123.serde.patch, HIVE-1123.service.2.patch, HIVE-1123.service.patch,
HIVE-1123.shims.2.patch, HIVE-1123.shims.patch
>> 
>> 
>> Fix checkstyle errors.
> 
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
> 


Mime
View raw message