hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zheng Shao (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1123) Checkstyle fixes
Date Wed, 03 Feb 2010 06:21:18 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828976#action_12828976
] 

Zheng Shao commented on HIVE-1123:
----------------------------------

Hi Carl, if you want us to commit the changes asap, can you exclude these 2 changes for now?
I mean the indentation problem and the case curly braces problem.

All other changes (spaces between tokens, javadoc, keywords, etc) seem good to me.

It will also be great if you can add the list of style changes you made into a file "checkstyle.txt"
or something so that we can publicize the common code convention problems to all the developers
and committers.


> Checkstyle fixes
> ----------------
>
>                 Key: HIVE-1123
>                 URL: https://issues.apache.org/jira/browse/HIVE-1123
>             Project: Hadoop Hive
>          Issue Type: Task
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>         Attachments: HIVE-1123.cli.patch, HIVE-1123.common.patch, HIVE-1123.contrib.patch,
HIVE-1123.hwi.patch, HIVE-1123.jdbc.patch, HIVE-1123.metastore.patch, HIVE-1123.ql.patch,
HIVE-1123.serde.patch, HIVE-1123.service.patch, HIVE-1123.shims.patch
>
>
> Fix checkstyle errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message