hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1123) Checkstyle fixes
Date Thu, 04 Feb 2010 22:45:28 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829831#action_12829831
] 

Carl Steinbach commented on HIVE-1123:
--------------------------------------


Here is a summary of the changes I made.
For each Checkstyle error message I reference the list of Checkstyle modules that
that signal that error, along with the original error count and error count after applying
the
patches.

* Variable 'X' must be private and have accessor methods.
* [VisbilityModifier|http://checkstyle.sourceforge.net/config_design.html#VisibilityModifier]
* 1260 -> 1128

* Name 'X' must match pattern 'X'.
* [ConstantName|http://checkstyle.sourceforge.net/config_naming.html#ConstantName], [LocalFinalVariableName|http://checkstyle.sourceforge.net/config_naming.html#LocalFinalVariableName],
[LocalVariableName|http://checkstyle.sourceforge.net/config_naming.html#LocalVariableName],
[MemberName|http://checkstyle.sourceforge.net/config_naming.html#MemberName], [MethodName|http://checkstyle.sourceforge.net/config_naming.html#MethodName],
[PackageName|http://checkstyle.sourceforge.net/config_naming.html#PackageName], [ParameterName|http://checkstyle.sourceforge.net/config_naming.html#ParameterName],
[StaticVariableName|http://checkstyle.sourceforge.net/config_naming.html#StaticVariableName],
[TypeName|http://checkstyle.sourceforge.net/config_naming.html#TypeName]
* 569 -> 447

* First sentence should end with a period.
* [JavadocStyle|http://checkstyle.sourceforge.net/config_javadoc.html#JavadocStyle]
* 529 -> 5

* Missing a Javadoc comment.
* [JavadocType|http://checkstyle.sourceforge.net/config_javadoc.html#JavadocType]
* 428 -> 15

* Line is longer than X characters.
* [LineLength|http://checkstyle.sourceforge.net/config_sizes.html#LineLength]
* 310 -> 101

* 'X' modifier out of order with the JLS suggestions.
* [ModifierOrder|http://checkstyle.sourceforge.net/config_modifier.html#ModifierOrder]
* 288 -> 0

* Avoid nested blocks.
* [AvoidNestedBlocks|http://checkstyle.sourceforge.net/config_blocks.html#AvoidNestedBlocks]
* 281 -> 184

* 'X' is followed by whitespace.
* [EmptyForIteratorPad|http://checkstyle.sourceforge.net/config_whitespace.html#EmptyForIteratorPad],
[NoWhitespaceAfter|http://checkstyle.sourceforge.net/config_whitespace.html#NoWhitespaceAfter],
[ParenPad|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad], [TypecastParenPad|http://checkstyle.sourceforge.net/config_whitespace.html#TypecastParenPad]
* 190 -> 1

* Redundant 'X' modifier.
* [RedundantModifer|http://checkstyle.sourceforge.net/config_modifier.html#RedundantModifier]
* 172 -> 0

* String literal expressions should be on the left side of an equals comparison.
* [EqualsAvoidNull|http://checkstyle.sourceforge.net/config_coding.html#EqualsAvoidNull]
* 97 -> 93

* Utility classes should not have a public or default constructor.
* [HideUtilityClassConstructor|http://checkstyle.sourceforge.net/config_design.html#HideUtilityClassConstructor]
* 55 -> 4

* Unused import - X
* [UnusedImports|http://checkstyle.sourceforge.net/config_imports.html#UnusedImports]
* 40 -> 5

* Array brackets at illegal position.
* [ArrayTypeStyle|http://checkstyle.sourceforge.net/config_misc.html#ArrayTypeStyle]
* 38 -> 18

* Redundant throws: 'X' is unchecked exception.
* [RedundantThrows|http://checkstyle.sourceforge.net/config_coding.html#RedundantThrows]
* 19 -> 0

* Inner assignments should be avoided.
* [InnerAssignment|http://checkstyle.sourceforge.net/config_coding.html#InnerAssignment]
* 16 -> 14

* 'X' construct must use '{}'s.
* [NeedBraces|http://checkstyle.sourceforge.net/config_blocks.html#NeedBraces]
* 10 -> 1

* Empty statement.
* [EmptyStatement|http://checkstyle.sourceforge.net/config_coding.html#EmptyStatement]
* 10 -> 4

* 'X' is not followed by whitespace.
* [ParenPad|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad], [TypecastParenPad|http://checkstyle.sourceforge.net/config_whitespace.html#TypecastParenPad],
[WhitespaceAfter|http://checkstyle.sourceforge.net/config_whitespace.html#WhitespaceAfter]
* 9 -> 0

* 'X' should be on the same line.
* [RightCurly|http://checkstyle.sourceforge.net/config_blocks.html#RightCurly]
* 8 -> 0

* 'X' is preceded with whitespace.
* [MethodParamPad|http://checkstyle.sourceforge.net/config_whitespace.html#MethodParamPad],
[NoWhitespaceBefore|http://checkstyle.sourceforge.net/config_whitespace.html#NoWhitespaceBefore],
[ParenPad|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
* 4 -> 0

* Redundant throws: 'X' is subclass of 'X'.
* [RedundantThrows|http://checkstyle.sourceforge.net/config_coding.html#RedundantThrows]
* 3 -> 1

* Class X should be declared as final.
* [FinalClass|http://checkstyle.sourceforge.net/config_design.html#FinalClass]
* 1 -> 0





> Checkstyle fixes
> ----------------
>
>                 Key: HIVE-1123
>                 URL: https://issues.apache.org/jira/browse/HIVE-1123
>             Project: Hadoop Hive
>          Issue Type: Task
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>         Attachments: HIVE-1123.checkstyle.patch, HIVE-1123.cli.2.patch, HIVE-1123.cli.patch,
HIVE-1123.common.2.patch, HIVE-1123.common.patch, HIVE-1123.contrib.2.patch, HIVE-1123.contrib.patch,
HIVE-1123.hwi.2.patch, HIVE-1123.hwi.patch, HIVE-1123.jdbc.2.patch, HIVE-1123.jdbc.patch,
HIVE-1123.metastore.2.patch, HIVE-1123.metastore.patch, HIVE-1123.ql.2.patch, HIVE-1123.ql.patch,
HIVE-1123.serde.2.patch, HIVE-1123.serde.patch, HIVE-1123.service.2.patch, HIVE-1123.service.patch,
HIVE-1123.shims.2.patch, HIVE-1123.shims.patch
>
>
> Fix checkstyle errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message