hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HIVE-1084) Cleanup Class names
Date Mon, 25 Jan 2010 02:58:36 GMT

     [ https://issues.apache.org/jira/browse/HIVE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Carl Steinbach updated HIVE-1084:
---------------------------------

    Attachment: cleanup-class-names.2.patch

Ensure that all Java class names begin with a capital letter.

* Move ql/plan/[a-z]*Desc.java to ql/plan/desc/[A-Z]*Desc.java
* Move ql/plan/*Work.java to ql/plan/work/*Work.java
* Move all annotations defined in ql to ql/annotations
* Move QB*.java, JoinCond, and JoinType from ql/parse to ql/parse/ast

I think moving these classes to new packages improves the organization of the code,
but it is also a necessity on case-insensitive filesystems like OS X's HFS that
can not handle file renames involving capitalization.

I applied this patch to a clean copy of trunk and noticed the following problems:
* Deleted files show up as modified files with size 0.
* The ql/plan/desc, ql/plan/work, ql/parse/ast, and ql/annotations directories and contents
are not recognized by SVN. You have to 'svn add' each directory.

The following script remedies these problems (run from trunk root):
{code}
#/bin/sh

for file in `find ql -name *.java -size 0`
do
    svn revert $file
    svn rm $file
done

svn add ql/src/java/org/apache/hadoop/hive/ql/plan/desc
svn add ql/src/java/org/apache/hadoop/hive/ql/plan/work
svn add ql/src/java/org/apache/hadoop/hive/ql/parse/ast
svn add ql/src/java/org/apache/hadoop/hive/ql/annotations
{code}



> Cleanup Class names
> -------------------
>
>                 Key: HIVE-1084
>                 URL: https://issues.apache.org/jira/browse/HIVE-1084
>             Project: Hadoop Hive
>          Issue Type: Task
>    Affects Versions: 0.6.0
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>         Attachments: cleanup-class-names.2.patch, cleanup-class-names.patch
>
>
> [Sun's Code Conventions for the Java Programming Language|http://java.sun.com/docs/codeconv/]
document stipulates that Java class names must begin with a capital letter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message