hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-924) Extract LogicalPlan and PhysicalPlan classes from SemanticAnalysis class
Date Mon, 14 Dec 2009 00:23:18 GMT

    [ https://issues.apache.org/jira/browse/HIVE-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789961#action_12789961
] 

Carl Steinbach commented on HIVE-924:
-------------------------------------

My preference is to do this in a separate patch, but to commit both patches
within a small window of time. All of these refactoring changes affect a large
number of files, and are disruptive to others since they result in a lot of
diffs. Pushing them in together helps to minimize the disruption.

However, if you think the risk of destabilization outweighs the inconvenience
of dealing with lots of diffs twice, then I am fine with waiting a while between
these two changes.


> Extract LogicalPlan and PhysicalPlan classes from SemanticAnalysis class
> ------------------------------------------------------------------------
>
>                 Key: HIVE-924
>                 URL: https://issues.apache.org/jira/browse/HIVE-924
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Carl Steinbach
>         Attachments: HIVE-924.patch
>
>
> Currently the SemanticAnalyzer class handles semantic analysis, as well as logical plan
generation and physical plan generation. I think it would be beneficial to extract distinct
LogicalPlan and PhysicalPlan classes from the SemanticAnalyzer, and have the query processing
phase be coordinated by a QueryCompiler class that would be responsible for triggering the
parsing, semantic analysis, logical plan generation, optimization, and physical plan generation
phases. This proposed reorganization of components would help to isolate the state of each
phase, and would also bring the source into closer alignment with the description of the query
compiler in the Hive design document on the wiki.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message