hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-862) CommandProcessor should return DriverResponse
Date Sat, 03 Oct 2009 23:36:23 GMT

    [ https://issues.apache.org/jira/browse/HIVE-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761974#action_12761974
] 

Edward Capriolo commented on HIVE-862:
--------------------------------------

This looks good to me.

I will follow up with 821 and change the hwi / classes and JSP.

> CommandProcessor should return DriverResponse
> ---------------------------------------------
>
>                 Key: HIVE-862
>                 URL: https://issues.apache.org/jira/browse/HIVE-862
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Edward Capriolo
>            Assignee: Bill Graham
>         Attachments: HIVE-862.1.patch
>
>
> Since Driver now returns DriverResponse CommandProcessor should return a similar object.
> {noformat}
> For reference here is how i want to use this:
> Currently:
> HWISessionItem.java
> private List<Integer> queryRet;
> private List<String>  queries;
> public void runQuery() {
>   //for each query in queries
>    if (instanceof driver) {
>       //other stuff here
>      queryRet.add( qp.run(cmd) );
>    } else {
>       queryRet.add(proc.run(cmd_1)  );
>    }
> }
> So I would like to refactor and use DriverResponse.
> private List<DriverResponse> queryRet;
> private List<String>  queries;
> public void runQuery() {
>   //for each query in queries
>    
>    if (instanceof driver) {
>       //other stuff here
>      queryRet.add( qp.run(cmd) );  //<--- this is fine
>    } else {
>       queryRet.add(proc.run(cmd_1)  ); <--this returns an int.
>    }
> }
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message