hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cyrus Katrak (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-545) Use ArrayList instead of Vector in single-threaded Hive code
Date Tue, 06 Oct 2009 04:01:31 GMT

    [ https://issues.apache.org/jira/browse/HIVE-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762496#action_12762496
] 

Cyrus Katrak commented on HIVE-545:
-----------------------------------

Patch attached. Tests still running, but looks good so far.
Sorry about the size of this, what started off as a quick fix sprawled into an gargantuan
search and replace of epic proportions:

-Replaced most instances of Vector with ArrayList
-Replaced most ArrayList variable declarations with List (ArrayList a = new ArrayList ->
List a = new ArrayList)
-Replaced most ArrayList method argument declarations with List ( doWork(ArrayList a) ->
doWork(List a) )
-Replaced most ArrayList template type declarations with List (Map<ArrayList<String>>
-> Map<List<String>>)

> Use ArrayList instead of Vector in single-threaded Hive code
> ------------------------------------------------------------
>
>                 Key: HIVE-545
>                 URL: https://issues.apache.org/jira/browse/HIVE-545
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Zheng Shao
>         Attachments: HIVE-545.patch
>
>
> Most of the Hive code is single-threaded, but sometimes we are using Vector instead of
the more efficient ArrayList.
> See http://java.sun.com/j2se/1.5.0/docs/api/java/util/ArrayList.html
> "This class (ArrayList) is roughly equivalent to Vector, except that it is unsynchronized."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message