hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-454) Support escaping of ; in strings in cli
Date Thu, 06 Aug 2009 13:55:17 GMT

    [ https://issues.apache.org/jira/browse/HIVE-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740073#action_12740073
] 

Edward Capriolo commented on HIVE-454:
--------------------------------------

Digging into this some more it seems that the query processor and cli driver would have to
work together in a different way.

As of now the CLIDriver is physically splitting on ';'  it can not tell the difference between
';' and '/;'. My patch adds some logic to detect '/;' and unescape it before passing to qp.run(String).

Right now we can argue that the CliDriver has an implicit 'autocommit=true'. We can make this
an explicit variable. with autocommit='false'  the query processor would hold a StringBuffer
or a queue of query strings. 'commit ' ; would cause QP to run each query in its queue.

This is a non-trivial change. If we add this feature we can set autocommit=true so the default
behavior does not change. For no though my patch has a fairly way to deal with this problem.


> Support escaping of ; in strings in cli
> ---------------------------------------
>
>                 Key: HIVE-454
>                 URL: https://issues.apache.org/jira/browse/HIVE-454
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Clients
>    Affects Versions: 0.3.0
>            Reporter: Ashish Thusoo
>            Assignee: Ashish Thusoo
>         Attachments: hive-454.patch
>
>
> If ; appears in string literals in a query the hive cli is not able to escape them properly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message