hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zheng Shao (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-720) Improve ByteStream by removing all synchronized method calls
Date Tue, 04 Aug 2009 20:11:14 GMT

    [ https://issues.apache.org/jira/browse/HIVE-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739129#action_12739129
] 

Zheng Shao commented on HIVE-720:
---------------------------------

Overall it looks good. Some nitpicks about class names:
1: ByteArrayInputBuffer -> NonSyncByteArrayInputStream, ByteArrayOutputBuffer -> NonSyncByteArrayOutputStream.
2. HiveDataInputBuffer -> NonSyncDataInputBuffer, HiveDataOutputBuffer -> NonSyncDataOutputBuffer

Also can we put the new classes into common/io instead of common?

Also, what is the reason that HiveDataInputBuffer inherits FilterInputStream, while HiveDataOutputBuffer
inherits DataOutputStream?
We might have discussed it before but I cannot remember. Can you put some comments into the
code?


> Improve ByteStream by removing all synchronized method calls
> ------------------------------------------------------------
>
>                 Key: HIVE-720
>                 URL: https://issues.apache.org/jira/browse/HIVE-720
>             Project: Hadoop Hive
>          Issue Type: Improvement
>            Reporter: Zheng Shao
>         Attachments: HIVE-720.1.patch
>
>
> org.apache.hadoop.hive.serde2.ByteStream has 2 inner classes: Input and Output, which
inherits from ByteArrayInputStream and ByteArrayOutputStream.
> Both these classes have a lot of sychronized methods, which make them really slow.
> We should let ByteStream.Input and ByteStream.Output directly inherit InputStream and
OutputStream so we don't need to call synchronized methods at all. This will help LazySimpleSerDe,
ColumnarSerDe as well as LazyBinarySerDe.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message