hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-716) Web Interface wait/notify, interface changes
Date Fri, 28 Aug 2009 18:18:32 GMT

    [ https://issues.apache.org/jira/browse/HIVE-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748927#action_12748927
] 

Vijay commented on HIVE-716:
----------------------------

It'd be great to have this committed soon in whatever process that makes sense. This absolutely
ups the usability.

One related problem I keep running into has to do with the ShimLoader.java class (./shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java).
As the sources are right now, when I run hwi, the shim loader cannot find the jetty shim class
since it's looking for org.apache.jetty.hive.shims.Jetty18Shims class (I'm using hadoop 0.18.3).
It seems like these classes have recently been moved to the package org.apache.jetty.hive.shims.
I simply change org.apache.jetty to org.apache.hadoop and it works but this does seem like
either a bug or incomplete code refactor/cleanup task.

> Web Interface wait/notify, interface changes
> --------------------------------------------
>
>                 Key: HIVE-716
>                 URL: https://issues.apache.org/jira/browse/HIVE-716
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Web UI
>         Environment: All
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>         Attachments: hive-716-2.diff, hive-716-3.diff, hive-716-4.diff, hive-716.diff,
hwi_query_box.png
>
>
> In TestHWISessionItem 
> Asserts are backwards
> {noformat}
> assertEquals(  searchItem.getQueryRet(), 0);
> {noformat}
> Should be
> {noformat}
> assertEquals( zero , searchItem.getQueryRet());
> {noformat}
> Wait/notify semantics can be added. This is helpful for end user, and cleaner in the
test case.
> {noformat}
> while (user1_item2.getStatus() != HWISessionItem.WebSessionItemStatus.QUERY_COMPLETE)
{
>   Thread.sleep(1);
> }
> {noformat}
> {noformat}
> synchronized (user1_item2.runnable) {
>   while (user1_item2.getStatus() != HWISessionItem.WebSessionItemStatus.QUERY_COMPLETE)
{
>      user1_item2.runnable.wait();
>   }
> }
> {noformat}
> The text box in the web interface should accept multiple queries separated by ';' like
the cli does. This will add more usability. No need for separate set processor pages. 
> setQuery(String) is replaced by setQueries(List<String>)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message