hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghotham Murthy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-590) Pass type information in genFileSinkPlan
Date Wed, 01 Jul 2009 23:28:47 GMT

    [ https://issues.apache.org/jira/browse/HIVE-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726268#action_12726268
] 

Raghotham Murthy commented on HIVE-590:
---------------------------------------

changes look good for the most part. a few comments:

* we should provide an additional method in HiveInterface.java which returns a SerDe given
a Schema. If we implement it once - we can reuse it in all the tests and in HiveResultSet.java
instead of duplicating the serde creation logic everywhere (including the dsp.setProperty()
calls). We can choose to do it in a later jira.
* use standard name for get method:   public boolean isUseJSONSerialize() {
* includes unnecessary changes to test results

> Pass type information in genFileSinkPlan
> ----------------------------------------
>
>                 Key: HIVE-590
>                 URL: https://issues.apache.org/jira/browse/HIVE-590
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Raghotham Murthy
>            Assignee: Namit Jain
>         Attachments: hive.590.1.patch
>
>
> Right now only column names are being passed between semanticanalyzer and fetchtask.
Once type information is passed, we can use LazySerDe to serialize the data (into json) in
Driver.getResults().
> Driver.getSchema() should then return a new thrift type ResultSchema instead of String:
> {code}
> struct ResultSchema {
>   // column names, types, comments
>  1: list<hive_metastore.FieldSchema> fieldSchemas,
>  // delimiters etc
>  2: map<string, string> properties
> }
> {code}
> Once this is done, the jdbc client can instantiate a simplified serde from the ResultSchema
and parse the query results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message