hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Namit Jain (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-405) Cleanup operator initialization
Date Thu, 16 Jul 2009 17:09:14 GMT

    [ https://issues.apache.org/jira/browse/HIVE-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732025#action_12732025
] 

Namit Jain commented on HIVE-405:
---------------------------------

Other than that, it looks good, you dont need to set 
state = State.INIT in initializeChildren()


the operator.initialize() will look like:

...

initializeOp()
state = INIT
initializeChildren()
..


initializechildren() can be a private method which no one else should call




> Cleanup operator initialization
> -------------------------------
>
>                 Key: HIVE-405
>                 URL: https://issues.apache.org/jira/browse/HIVE-405
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.4.0
>            Reporter: Zheng Shao
>            Assignee: Prasad Chakka
>            Priority: Critical
>         Attachments: hive-405.6.patch, hive-405.7.patch, hive-405.patch
>
>
> We are always passing the same ObjectInspector, so there is no need to pass it again
and again in forward.
> Also there is a problem that can ONLY be fixed by passing ObjectInspector in init: Outer
Joins - Outer Joins may not be able to get ObjectInspectors for all inputs, as a result, there
is no way to construct an output ObjectInspector based on the inputs. Currently we have hard-coded
code that assumes joins are always outputting Strings, which did break but was hidden by the
old framework (because we do toString() when serializing the output, and toString() is defined
for all Java Classes).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message