hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Namit Jain (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-555) create temporary function support not only udf, but also udaf, genericudf, etc.
Date Wed, 08 Jul 2009 21:53:14 GMT

    [ https://issues.apache.org/jira/browse/HIVE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728921#action_12728921
] 

Namit Jain commented on HIVE-555:
---------------------------------

Mostly looks good - I had a couple of minor comments.

1. Can you move 

+  /**
+   * Return a ordianl from an integer.
+   */
+  public static String getOrdinal(int i) {
+    int unit = i % 10;
+    return (i <= 0) ?  ""
+        : (i != 11 && unit == 1) ?  i + "st"
+        : (i != 12 && unit == 2) ?  i + "nd"
+        : (i != 13 && unit == 3) ?  i + "rd"
+        : i + "th";
+  }
   


to the test itself instead of GenericUDFUtils

(change ordianl to ordinal)

2. add a test which creates a temporary function on a existing generic udf.
3. add a negative test - the class does not exist

> create temporary function support not only udf, but also udaf,  genericudf, etc.
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-555
>                 URL: https://issues.apache.org/jira/browse/HIVE-555
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.4.0
>            Reporter: Min Zhou
>            Assignee: Min Zhou
>             Fix For: 0.4.0
>
>         Attachments: HIVE-555-1.patch, HIVE-555-2.patch
>
>
> Right now, command 'create temporary function' only support  udf. 
> we can also let user write their udaf, generic udf, and write generic udaf in the future.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message