hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghotham Murthy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-577) return correct comment of a column from ThriftHiveMetastore.Iface.get_fields
Date Tue, 30 Jun 2009 20:42:47 GMT

    [ https://issues.apache.org/jira/browse/HIVE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725797#action_12725797
] 

Raghotham Murthy commented on HIVE-577:
---------------------------------------

Check HIVE-590. We are going to fix Driver.getSchema() to return a structure rather than return
a string which needs to be parsed again in the client. 

I am wondering if we can get rid of duplicate logic of getting schema of table or query result
in HiveMetaStore vs Driver. I couldnt find any place (other than thrift generated code) where
we call get_fields(). So, do we really need this method at all given that Driver will provide
this functionality?

Regarding this patch, can you add a test?

> return correct comment of a column from ThriftHiveMetastore.Iface.get_fields
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-577
>                 URL: https://issues.apache.org/jira/browse/HIVE-577
>             Project: Hadoop Hive
>          Issue Type: Sub-task
>            Reporter: Min Zhou
>            Assignee: Min Zhou
>         Attachments: HIVE-577.1.patch, HIVE-577.2.patch
>
>
> comment of each column hasnot been retrieved correct right now , 
> FieldSchema.getComment() will return a string "from derserializer".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message