hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "He Yongqiang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-472) HiveFileFormatUtils's checkInputFormat does not include RCFile
Date Mon, 08 Jun 2009 02:08:07 GMT

    [ https://issues.apache.org/jira/browse/HIVE-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717117#action_12717117
] 

He Yongqiang commented on HIVE-472:
-----------------------------------

Yes. It will be better if we can move this method out. But it has some problem since hive
does not have its own InputFormat definition. 
The input formats hive uses right now are mainly from hadoop core, such as SequenceFileInputFormat,
IgnoreKeyFileInputFormat etc. And we can not add a validInput() to hadoop's input format classes.
One option is to create another class hierarchy (InputFormatChecker) in Hive parallized with
FileFomat.
Another option is to keep the FileFormat's checkInputFormat, and check whether the input format
argument has a method "hiveValidInput". If find one, use it. And if not use the old logic
in HiveFormatUtils. 

> HiveFileFormatUtils's checkInputFormat does not include RCFile
> --------------------------------------------------------------
>
>                 Key: HIVE-472
>                 URL: https://issues.apache.org/jira/browse/HIVE-472
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: He Yongqiang
>            Assignee: He Yongqiang
>         Attachments: hive.472.1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message