hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Namit Jain (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-416) Get rid of backtrack in Hive.g
Date Fri, 17 Apr 2009 16:12:15 GMT

    [ https://issues.apache.org/jira/browse/HIVE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700230#action_12700230
] 

Namit Jain commented on HIVE-416:
---------------------------------

The changes look good to me.
+1

I can test and commit them, but will wait for a couple of hours if anyone has any issues,
since many people have been reviewing this code.
I will wait till Firday evening (say around 5pm), if no-one has any objections, I will commit
this (if the tests pass)

> Get rid of backtrack in Hive.g
> ------------------------------
>
>                 Key: HIVE-416
>                 URL: https://issues.apache.org/jira/browse/HIVE-416
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.4.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.4.0
>
>         Attachments: HIVE-416.1.1.patch, HIVE-416.1.patch
>
>
> Hive.g now still uses "backtrack=true". "backtrack" not only slows down the parsing in
case of error, it can also produce wrong syntax error messages (usually based on the last
try of the backtracking).
> We should follow http://www.antlr.org/wiki/display/ANTLR3/How+to+remove+global+backtracking+from+your+grammar
to remove the need of doing backtrack.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message