hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zheng Shao (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-142) Create a metastore check command
Date Thu, 08 Jan 2009 19:46:59 GMT

    [ https://issues.apache.org/jira/browse/HIVE-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662090#action_12662090
] 

Zheng Shao commented on HIVE-142:
---------------------------------

Test is failing. Can you try the following test?
It's not that critical (It's a negative query and only the error message is different), but
I feel the current error message is more intuitive.

ant test -Dtestcase=TestNegativeCliDriver -Dqfile=invalid_create_tbl2.q

    [junit] diff -I \(file:\)\|\(/tmp/.*\) /data/users/zshao/sync/apache-trunk-HIVE-142/build/ql/test/logs/clientnegative/invalid_create_tbl2.q.out
/data/users/zshao/sync/apache-trunk-HIVE-142/ql/src/test/results/clientnegative/invalid_create_tbl2.q.out
    [junit] 1c1
    [junit] < FAILED: Parse Error: line 1:0 cannot recognize input 'create'
    [junit] ---
    [junit] > FAILED: Parse Error: line 1:7 mismatched input 'tabl' expecting KW_TEMPORARY
    [junit] Exception: Client execution results dailed with error code = 1
    [junit] junit.framework.AssertionFailedError: Client execution results dailed with error
code = 1
    [junit]     at junit.framework.Assert.fail(Assert.java:47)
    [junit]     at org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_invalid_create_tbl2(TestNegativeCliDriver.java:56)
    [junit]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    [junit]     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    [junit]     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    [junit]     at java.lang.reflect.Method.invoke(Method.java:597)
    [junit]     at junit.framework.TestCase.runTest(TestCase.java:154)
    [junit]     at junit.framework.TestCase.runBare(TestCase.java:127)
    [junit]     at junit.framework.TestResult$1.protect(TestResult.java:106)
    [junit]     at junit.framework.TestResult.runProtected(TestResult.java:124)
    [junit]     at junit.framework.TestResult.run(TestResult.java:109)
    [junit]     at junit.framework.TestCase.run(TestCase.java:118)
    [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:208)
    [junit]     at junit.framework.TestSuite.run(TestSuite.java:203)
    [junit]     at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:420)
    [junit]     at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:911)
    [junit]     at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:768)
    [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 9.533 sec


> Create a metastore check command
> --------------------------------
>
>                 Key: HIVE-142
>                 URL: https://issues.apache.org/jira/browse/HIVE-142
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Metastore
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>             Fix For: 0.2.0
>
>         Attachments: HIVE-142.patch, HIVE-142.patch, HIVE-142.patch, HIVE-142.patch,
HIVE-142.patch
>
>
> We need a command to verify that the information in the metastore reflects the data that
is on hdfs. For example partitions can be deleted on hdfs but still be in the metastore.
> From Joydeep Sen Sarma, see ticket HIVE-126 for the full comment:
> for a command line interface - one might want to check the entire database or just a
table or even just one partition. other metadata checks will also be added over time (for
example - do the file types on disk agree with metadata records, bucketing information etc).
So, here's a strawman proposal for a new command:
> alter table <DB>[.TABLE [PARTITION-SPEC]] check [TYPE-LIST]
> where TYPE by default is 'all' (check for all kinds of errors), but can be specified
to a specific type. For example - in this case - we can have a type called 'partitions' (and
then over time we can add other types like 'fileformat' etc.). for v1 - we can just drop the
type-list altogether.
> the check command can produce a list of things that need to be done to fix the format
(like adding any directories not in the metastore - but in hdfs - to the metastore). actually
performing of such steps would require a user confirmation (y/n).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message