hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Namit Jain (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-102) Refactor DDLTask
Date Wed, 03 Dec 2008 22:15:44 GMT

    [ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653002#action_12653002

Namit Jain commented on HIVE-102:

Looks good. Can you add some comments for each of the functions ? After that, it should be
good to go.
Also, can you add java docs for each of these new functions that you added.

Eventually, it might be good to break it up into separate tasks. The abstract class DDLWork
can have various subclasses:
showTablesWork, DescribeTableWork etc. and a separate task for each of them. This will make
them completely independent.
However, that can be done in a follow-up

> Refactor DDLTask
> ----------------
>                 Key: HIVE-102
>                 URL: https://issues.apache.org/jira/browse/HIVE-102
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>            Priority: Minor
>             Fix For: 0.20.0
>         Attachments: HIVE-102.patch
> DDLTask have one method that is around 400 lines long. Refactor the if statements into
methods to increase readability.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message