hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Thusoo (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-177) Allow specifying custom input and output format in CREATE TABLE
Date Thu, 18 Dec 2008 19:53:44 GMT

    [ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657874#action_12657874
] 

Ashish Thusoo commented on HIVE-177:
------------------------------------

Looks good to me.

There are a few minor comments:
1. I think instead of hardcoding the class name strings in the variables used to set the input
and output formats for sequence and text files, we should instead use the Class.getName()
function so that if we move those classes around later, we do not break these strings.
2. Can we make the run time error code better for the case where  negative test case for voids.


> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
>                 Key: HIVE-177
>                 URL: https://issues.apache.org/jira/browse/HIVE-177
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: David Phillips
>            Assignee: David Phillips
>         Attachments: hive-create-fileformat.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message