hadoop-hive-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nzh...@apache.org
Subject svn commit: r949342 - in /hadoop/hive/trunk: .checkstyle CHANGES.txt README.txt build.xml checkstyle/checkstyle.xml
Date Sat, 29 May 2010 06:04:50 GMT
Author: nzhang
Date: Sat May 29 06:04:50 2010
New Revision: 949342

URL: http://svn.apache.org/viewvc?rev=949342&view=rev
Log:
HIVE-1198. When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle
problems as errors. (Arvind Prabhakar via Ning Zhang)

Modified:
    hadoop/hive/trunk/.checkstyle
    hadoop/hive/trunk/CHANGES.txt
    hadoop/hive/trunk/README.txt
    hadoop/hive/trunk/build.xml
    hadoop/hive/trunk/checkstyle/checkstyle.xml

Modified: hadoop/hive/trunk/.checkstyle
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/.checkstyle?rev=949342&r1=949341&r2=949342&view=diff
==============================================================================
--- hadoop/hive/trunk/.checkstyle (original)
+++ hadoop/hive/trunk/.checkstyle Sat May 29 06:04:50 2010
@@ -5,6 +5,6 @@
     <additional-data name="protect-config-file" value="true"/>
   </local-check-config>
   <fileset name="Hive Java Source Files" enabled="true" check-config-name="Hive Checkstyle"
local="true">
-    <file-match-pattern match-pattern="^(?!build).*java$" include-pattern="true"/>
+    <file-match-pattern match-pattern="^(?!(build|ant)).*java$" include-pattern="true"/>
   </fileset>
 </fileset-config>

Modified: hadoop/hive/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/CHANGES.txt?rev=949342&r1=949341&r2=949342&view=diff
==============================================================================
--- hadoop/hive/trunk/CHANGES.txt (original)
+++ hadoop/hive/trunk/CHANGES.txt Sat May 29 06:04:50 2010
@@ -193,6 +193,10 @@ Trunk -  Unreleased
     HIVE-1349. Do not pull counters of non initialized jobs.
     (Dmytro Molkov via Ning Zhang)
 
+    HIVE-1198. When checkstyle is activated for Hive in Eclipse environment, 
+    it shows all checkstyle problems as errors.
+    (Arvind Prabhakar via Ning Zhang)
+
   OPTIMIZATIONS
 
   BUG FIXES

Modified: hadoop/hive/trunk/README.txt
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/README.txt?rev=949342&r1=949341&r2=949342&view=diff
==============================================================================
--- hadoop/hive/trunk/README.txt (original)
+++ hadoop/hive/trunk/README.txt Sat May 29 06:04:50 2010
@@ -336,7 +336,7 @@ FUTURE FEATURES
 * Table statistics for query optimization.
 
 Developing Hive using Eclipse
-------------------------
+-----------------------------
 1. Follow the 3 steps in "Downloading and building" section above
 
 2. Generate test files for eclipse:
@@ -356,6 +356,20 @@ Developing Hive using Eclipse
 4. Run the CLI or a set of test cases by right clicking on one of the
    *.launch configurations and selection Run or Debug.
 
+Enabling Checkstyle Plugin in Eclipse
+-------------------------------------
+1. Follow the steps in "Developing Hive using Eclipse" to import
+   Hive project in your Eclipse workbench.
+
+2. If you do not have Checkstyle plugin for eclipse, install it
+   before proceeding to next step. For more information refer to
+   http://eclipse-cs.sourceforge.net/.
+
+3. In the package navigator, select the hive project, right-click
+   and select Checkstyle > Activate Checkstyle. This will cause
+   the checkstyle plugin to activate and analyze the project sources.
+ 
+
 Development Tips
 ------------------------
 * You may use the following line to test a specific testcase with a specific query file.

Modified: hadoop/hive/trunk/build.xml
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/build.xml?rev=949342&r1=949341&r2=949342&view=diff
==============================================================================
--- hadoop/hive/trunk/build.xml (original)
+++ hadoop/hive/trunk/build.xml Sat May 29 06:04:50 2010
@@ -530,6 +530,7 @@
   		failOnViolation="false">
       <fileset dir="${hive.root}">
         <exclude name="build/**"/>
+        <exclude name="ant/**"/>
         <include name="**/*.java"/>
       </fileset>
       <formatter type="plain" toFile="${checkstyle.build.dir}/checkstyle-errors.txt"/>

Modified: hadoop/hive/trunk/checkstyle/checkstyle.xml
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/checkstyle/checkstyle.xml?rev=949342&r1=949341&r2=949342&view=diff
==============================================================================
--- hadoop/hive/trunk/checkstyle/checkstyle.xml (original)
+++ hadoop/hive/trunk/checkstyle/checkstyle.xml Sat May 29 06:04:50 2010
@@ -50,6 +50,9 @@
 
 <module name="Checker">
 
+  <!-- setting the default severity to warning -->
+  <property name="severity" value="warning"/>
+
   <!-- Checks that a package.html file exists for each package.     -->
   <module name="JavadocPackage"/>
 



Mime
View raw message