Mailing-List: contact user-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@hadoop.apache.org
Received-SPF: pass (athena.apache.org: domain of a.eremihin@corp.badoo.com
 designates 209.85.215.43 as permitted sender)
Message-ID: <534FACD3.8040907@corp.badoo.com>
Date: Thu, 17 Apr 2014 14:28:35 +0400
From: Eremikhin Alexey <a.eremihin@corp.badoo.com>
User-Agent: Mozilla/5.0 (X11; Linux i686;
 rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: user@hadoop.apache.org
Subject: log4j.appender.DRFA.MaxBackupIndex is not it nonsense!?
Content-Type: multipart/alternative;
 boundary="------------070100040103080905050502"

This is a multi-part message in MIME format.
--------------070100040103080905050502
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi everyone!
I've started looking about logs retention on Hadoop and noticed 
interesting option in default Hadoop log4j.properties configuration
# 30-day backup
# log4j.appender.DRFA.MaxBackupIndex=30

I've enabled it and it produced no effect on existing files even after 
rotation happened. That caused me start reading source code of log4j.
There is a base class FileAppender which has 2 children 
RollingFileAppender(RFA) and DailyRollingFileAppender(DRFA).

RFA enumerates files ascending and on each rotation increases log file 
id from 1 up to MaxBackupIndex and removes last file.
http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/RollingFileAppender.html

DRFA uses date to distinct logs files but has no retention techniques 
inside.
http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/DailyRollingFileAppender.html

That means MaxBackupIndex can't have any effect on DRFA at all. And that 
means property name log4j.appender.DRFA.MaxBackupIndex has no sense and 
no effect.
You can easily google this parameter and find plenty complaints it does 
not work.

Yes there are some projects about adding retention to DRFA but these 
classes have different names.
http://wiki.apache.org/logging-log4j/DailyRollingFileAppender - 
DailyMaxRollingFileAppender


You can find this parameter even in last stable distribution.
http://www.eu.apache.org/dist/hadoop/common/stable/hadoop-2.2.0.tar.gz
file
/hadoop-2.2.0/etc/hadoop/log4.properties


What I'm doing wrong? 8-\

--------------070100040103080905050502
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Hi everyone!<br>
    I've started looking about logs retention on Hadoop and noticed
    interesting option in default Hadoop log4j.properties configuration<br>
    # 30-day backup<br>
    # log4j.appender.DRFA.MaxBackupIndex=30<br>
    <br>
    I've enabled it and it produced no effect on existing files even
    after rotation happened. That caused me start reading source code of
    log4j.<br>
    There is a base class FileAppender which has 2 children
    RollingFileAppender(RFA) and DailyRollingFileAppender(DRFA).<br>
    <br>
    RFA enumerates files ascending and on each rotation increases log
    file id from 1 up to MaxBackupIndex and removes last file.<br>
<a class="moz-txt-link-freetext" href="http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/RollingFileAppender.html">http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/RollingFileAppender.html</a><br>
    <br>
    DRFA uses date to distinct logs files but has no retention
    techniques inside.<br>
<a class="moz-txt-link-freetext" href="http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/DailyRollingFileAppender.html">http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/DailyRollingFileAppender.html</a><br>
    <br>
    That means MaxBackupIndex can't have any effect on DRFA at all. And
    that means property name log4j.appender.DRFA.MaxBackupIndex has no
    sense and no effect.<br>
    You can easily google this parameter and find plenty complaints it
    does not work.<br>
    <br>
    Yes there are some projects about adding retention to DRFA but these
    classes have different names.<br>
    <a class="moz-txt-link-freetext" href="http://wiki.apache.org/logging-log4j/DailyRollingFileAppender">http://wiki.apache.org/logging-log4j/DailyRollingFileAppender</a> - <span
      class="line"><span class="Comment">DailyMaxRollingFileAppender<br>
        <br>
        <br>
        You can find this parameter even in last stable distribution.<br>
<a class="moz-txt-link-freetext" href="http://www.eu.apache.org/dist/hadoop/common/stable/hadoop-2.2.0.tar.gz">http://www.eu.apache.org/dist/hadoop/common/stable/hadoop-2.2.0.tar.gz</a><br>
        file <br>
      </span></span><span class="line"><span class="Comment">/hadoop-2.2.0/etc/hadoop/log4.properties</span></span>
    <meta name="qrichtext" content="1">
    <br>
    <br>
    <br>
    What I'm doing wrong? 8-\<br>
    <meta name="qrichtext" content="1">
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    <style type="text/css">
p, li { white-space: pre-wrap; }
</style>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    <style type="text/css">
p, li { white-space: pre-wrap; }
</style>
  </body>
</html>

--------------070100040103080905050502--