Return-Path: X-Original-To: apmail-hadoop-hdfs-user-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-user-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 598AF10D69 for ; Sun, 16 Feb 2014 08:54:58 +0000 (UTC) Received: (qmail 34061 invoked by uid 500); 16 Feb 2014 08:54:50 -0000 Delivered-To: apmail-hadoop-hdfs-user-archive@hadoop.apache.org Received: (qmail 33974 invoked by uid 500); 16 Feb 2014 08:54:46 -0000 Mailing-List: contact user-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@hadoop.apache.org Delivered-To: mailing list user@hadoop.apache.org Received: (qmail 33962 invoked by uid 99); 16 Feb 2014 08:54:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Feb 2014 08:54:44 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of samliuhadoop@gmail.com designates 209.85.216.180 as permitted sender) Received: from [209.85.216.180] (HELO mail-qc0-f180.google.com) (209.85.216.180) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Feb 2014 08:54:38 +0000 Received: by mail-qc0-f180.google.com with SMTP id i17so22064938qcy.25 for ; Sun, 16 Feb 2014 00:54:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=nir/bqzxw1efEWtAYkTdkrLoWZaRKw3uDd9UgyPiUNE=; b=mjRZtvT4LGbpe7152pR6S1AY8tRK7iKbmJTO0DBBIIl8bF5z+lja6aCmIHEW7Y0SSb Hq4xgtWLFN51tbtUUchrnxz66GYx6sHWFnNE8Yrdauj6EWEWBGAv2tZ0txp8WAQE9yRZ hro3OuVaxSBkyOtxfVhKzizoLw1vO83LBA+kFuPClFJzSKiywftL7kldKyr4bawUgoSd qiPmW9ECAvzJVKZeCSP7a8WRZtMcA/CZ9wYIK29ER+7NWqUico8lM9K/9J3hcHhfMk40 1x/JYl/oxF1wkBVg4cZjRSU331yjMLBYgRkJVmQ1a271C30a1crnzFsHe4UtL0lPI7Nd qodQ== MIME-Version: 1.0 X-Received: by 10.224.61.2 with SMTP id r2mr27155298qah.49.1392540858165; Sun, 16 Feb 2014 00:54:18 -0800 (PST) Received: by 10.96.77.162 with HTTP; Sun, 16 Feb 2014 00:54:18 -0800 (PST) In-Reply-To: References: Date: Sun, 16 Feb 2014 16:54:18 +0800 Message-ID: Subject: Re: How to submit the patch MAPREDUCE-4490.patch which works for branch-1.2, not trunk? From: sam liu To: "user@hadoop.apache.org" Content-Type: multipart/alternative; boundary=001a11c3ddf82facd804f2822f06 X-Virus-Checked: Checked by ClamAV on apache.org --001a11c3ddf82facd804f2822f06 Content-Type: text/plain; charset=ISO-8859-1 Hi Arpit, Thanks for your guide! As a new contributor, I still have following two questions need your help: 1) So I guess I should run 'test-patch.sh' on my local environment against branch-1.2, not on Apache Hadoop test server, right? 2) On branch-1.2, I found the 'test-patch.sh' is on ./src/test/bin/test-patch.sh, not ./dev-support/test-patch.sh. My command is 'sh ./src/test/bin/test-patch.sh MAPREDUCE-4490.patch', however failed with message 'ERROR: usage ./src/test/bin/test-patch.sh HUDSON [args] | DEVELOPER [args]'. What's the correct way to manually run 'test-patch.sh'? 2014-02-15 5:25 GMT+08:00 Arpit Agarwal : > Hi Sam, > > Hadoop Jenkins does not accept patches for 1.x. > > You can manually run 'test-patch.sh' to verify there are no regressions > introduced by your patch and copy-paste the results into a Jira comment. > > > On Thu, Feb 13, 2014 at 10:50 PM, sam liu wrote: > >> Hi Experts, >> >> I have been working on the JIRA >> https://issues.apache.org/jira/browse/MAPREDUCE-4490 and attached >> MAPREDUCE-4490.patch which could fix this jira. I would like to contribute >> my patch to community, but encountered some issues. >> >> MAPREDUCE-4490 is an issue on Hadoop-1.x versions, and my patch based on >> the latest code of origin/branch-1.2. However, current trunk bases on Yarn >> and does not has such issue any more. So my patch could not be applied on >> current trunk code, and it's actually no need to generate a similar patch >> on trunk at all. >> >> How to submit the patch MAPREDUCE-4490.patch only to origin/branch-1.2, >> not trunk? Is it allowed by Apache Hadoop? >> >> Thanks! >> > > > CONFIDENTIALITY NOTICE > NOTICE: This message is intended for the use of the individual or entity > to which it is addressed and may contain information that is confidential, > privileged and exempt from disclosure under applicable law. If the reader > of this message is not the intended recipient, you are hereby notified that > any printing, copying, dissemination, distribution, disclosure or > forwarding of this communication is strictly prohibited. If you have > received this communication in error, please contact the sender immediately > and delete it from your system. Thank You. --001a11c3ddf82facd804f2822f06 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi Arpit,

Thanks for your= guide!=A0 As a new contributor, I still have following two questions need = your help:

1) So I guess I should run 'test-patch.sh' = on my local environment against branch-1.2, not on Apache Hadoop test serve= r, right?
2) On branch-1.2, I found the 'test-patch.sh' is on ./src/tes= t/bin/test-patch.sh, not ./dev-support/test-patch.sh. My command is 'sh= ./src/test/bin/test-patch.sh MAPREDUCE-4490.patch', however failed wit= h message 'ERROR: usage ./src/test/bin/test-patch.sh HUDSON [args] | DE= VELOPER [args]'. What's the correct way to manually run 'test-p= atch.sh'?


=


2014-02-15 5:= 25 GMT+08:00 Arpit Agarwal <aagarwal@hortonworks.com>= :
Hi Sam,

Hadoop = Jenkins does not accept patches for 1.x.

You can manually run = 'test-patch.sh' to verify there are no regressions introduced by yo= ur patch and copy-paste the results into a Jira comment.


On Thu, Feb 13, 2014 at 10:50 PM, sam liu <samliuhad= oop@gmail.com> wrote:
Hi Experts,
I have been working on the JIRA https://issues.apache.org/j= ira/browse/MAPREDUCE-4490 and attached MAPREDUCE-4490.patch which could= fix this jira. I would like to contribute my patch to community, but encou= ntered some issues.

MAPREDUCE-4490 is an issue on Hadoop-1.x versions, and my patch based o= n the=A0 latest code of origin/branch-1.2. However, current trunk bases on = Yarn and does not has such issue any more. So my patch could not be applied= on current trunk code, and it's actually no need to generate a similar= patch on trunk at all.

How to submit the patch MAPREDUCE-4490.patch only to origin/= branch-1.2, not trunk? Is it allowed by Apache Hadoop?

Th= anks!


CONFIDENTIALITY NOTICE
NOTICE: This= message is intended for the use of the individual or entity to which it is= addressed and may contain information that is confidential, privileged and= exempt from disclosure under applicable law. If the reader of this message= is not the intended recipient, you are hereby notified that any printing, = copying, dissemination, distribution, disclosure or forwarding of this comm= unication is strictly prohibited. If you have received this communication i= n error, please contact the sender immediately and delete it from your syst= em. Thank You.

--001a11c3ddf82facd804f2822f06--