hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDFS-15546) Remove duplicate initializeGenericKeys method when creating DFSZKFailoverController
Date Fri, 28 Aug 2020 10:25:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-15546?focusedWorklogId=475791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475791
]

ASF GitHub Bot logged work on HDFS-15546:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Aug/20 10:24
            Start Date: 28/Aug/20 10:24
    Worklog Time Spent: 10m 
      Work Description: jianghuazhu opened a new pull request #2256:
URL: https://github.com/apache/hadoop/pull/2256


   …ng DFSZKFailoverController
   
   ## NOTICE
   
   Please create an issue in ASF JIRA before opening a pull request,
   and you need to set the title of the pull request which starts with
   the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
   For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 475791)
    Remaining Estimate: 0h
            Time Spent: 10m

> Remove duplicate initializeGenericKeys method when creating DFSZKFailoverController
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-15546
>                 URL: https://issues.apache.org/jira/browse/HDFS-15546
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: jianghua zhu
>            Assignee: jianghua zhu
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When calling the DFSZKFailoverController#create() method, call NameNode#initializeGenericKeys()
twice.
> First call:
> DFSZKFailoverController#create() {
> ...
> NameNode.initializeGenericKeys(localNNConf, nsId, nnId);
> ...
> }
> The second call:
> NNHAServiceTarget construction method:
> NNHAServiceTarget() {
> ...
> NameNode.initializeGenericKeys(targetConf, nsId, nnId);
> ...
> }
> In fact, the parameters passed in the two calls are the same. Here you can remove the
first call without affecting the program itself.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message