hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-2260) Avoid evaluation of LOG.trace and LOG.debug statement in the read/write path (HDDS)
Date Tue, 08 Oct 2019 16:51:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-2260?focusedWorklogId=325182&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325182
]

ASF GitHub Bot logged work on HDDS-2260:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Oct/19 16:50
            Start Date: 08/Oct/19 16:50
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on pull request #1612: HDDS-2260. Avoid evaluation
of LOG.trace and LOG.debug statement in the read/write path (HDDS).
URL: https://github.com/apache/hadoop/pull/1612#discussion_r332621171
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java
 ##########
 @@ -216,9 +218,11 @@ private void deleteKeyValueContainerBlocks(
               DFSUtil.string2Bytes(OzoneConsts.DELETED_KEY_PREFIX + blk);
           if (containerDB.getStore().get(deletingKeyBytes) != null
               || containerDB.getStore().get(deletedKeyBytes) != null) {
-            LOG.debug(String.format(
-                "Ignoring delete for block %d in container %d."
-                    + " Entry already added.", blk, containerId));
+            if (LOG.isDebugEnabled()) {
+              LOG.debug(String.format(
+                  "Ignoring delete for block %d in container %d."
 
 Review comment:
   Use {}
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 325182)
    Time Spent: 3h  (was: 2h 50m)

> Avoid evaluation of LOG.trace and LOG.debug statement in the read/write path (HDDS)
> -----------------------------------------------------------------------------------
>
>                 Key: HDDS-2260
>                 URL: https://issues.apache.org/jira/browse/HDDS-2260
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Client, Ozone Datanode
>    Affects Versions: 0.4.0
>            Reporter: Mukul Kumar Singh
>            Assignee: Siddharth Wagle
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> LOG.trace and LOG.debug with logging information will be evaluated even when debug/trace
logging is disabled. This jira proposes to wrap all the trace/debug logging with 
> LOG.isDebugEnabled and LOG.isTraceEnabled to prevent the logging.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message