hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-2237) KeyDeletingService throws NPE if it's started too early
Date Fri, 04 Oct 2019 16:50:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-2237?focusedWorklogId=323563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323563
]

ASF GitHub Bot logged work on HDDS-2237:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Oct/19 16:49
            Start Date: 04/Oct/19 16:49
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on issue #1584: HDDS-2237. KeyDeletingService
throws NPE if it's started too early
URL: https://github.com/apache/hadoop/pull/1584#issuecomment-538475911
 
 
   Thank You @elek for the contribution and @arp7 for the review.
   I have committed this to the trunk.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 323563)
    Time Spent: 1h 10m  (was: 1h)

> KeyDeletingService throws NPE if it's started too early
> -------------------------------------------------------
>
>                 Key: HDDS-2237
>                 URL: https://issues.apache.org/jira/browse/HDDS-2237
>             Project: Hadoop Distributed Data Store
>          Issue Type: Task
>          Components: om
>            Reporter: Marton Elek
>            Assignee: Marton Elek
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> 1. OzoneManager starts KeyManager
> 2. KeyManager starts KeyDeletingService
> 3. KeyDeletingService uses OzoneManager.isLeader()
> 4. OzoneManager.isLeader() uses omRatisServer
> 5. omRatisServer can be null (bumm)
>  
> Now the initialization order in OzoneManager:
>  
> new KeymanagerServer() *Includes start()!!!!*
> omRatisServer initialization
> start() (includes KeyManager.start())
>  
> The solution seems to be easy: start the key manager only from the OzoneManager.start()
and not from the OzoneManager.instantiateServices()



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message