hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-2233) Remove ByteStringHelper and refactor the code to the place where it used
Date Mon, 07 Oct 2019 03:42:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-2233?focusedWorklogId=324135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324135
]

ASF GitHub Bot logged work on HDDS-2233:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Oct/19 03:41
            Start Date: 07/Oct/19 03:41
    Worklog Time Spent: 10m 
      Work Description: bshashikant commented on pull request #1596: HDDS-2233 - Remove ByteStringHelper
and refactor the code to the place where it used
URL: https://github.com/apache/hadoop/pull/1596#discussion_r331837192
 
 

 ##########
 File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ByteStringConversion.java
 ##########
 @@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.hadoop.hdds.scm;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.ozone.OzoneConfigKeys;
+import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
+import org.apache.ratis.thirdparty.com.google.protobuf.UnsafeByteOperations;
+
+import java.nio.ByteBuffer;
+import java.util.function.Function;
+
+/**
+ * Helper class to create a conversion function from ByteBuffer to ByteString
+ * based on the property
+ * {@link OzoneConfigKeys#OZONE_UNSAFEBYTEOPERATIONS_ENABLED} in the
+ * Ozone configuration.
+ */
+public final class ByteStringConversion {
+  private ByteStringConversion(){} // no instantiation.
+
+  /**
+   * Creates the conversion function to be used to convert ByteBuffers to
+   * ByteString instances to be used in protobuf messages.
+   *
+   * @param config the Ozone configuration
+   * @return the conversion function defined by
+   *          {@link OzoneConfigKeys#OZONE_UNSAFEBYTEOPERATIONS_ENABLED}
+   * @see <pre>ByteBuffer</pre>
+   */
+  public static Function<ByteBuffer, ByteString> createByteBufferConversion(
+      Configuration config){
+    boolean unsafeEnabled =
+        config!=null && config.getBoolean(
+            OzoneConfigKeys.OZONE_UNSAFEBYTEOPERATIONS_ENABLED,
+            OzoneConfigKeys.OZONE_UNSAFEBYTEOPERATIONS_ENABLED_DEFAULT);
+    if (unsafeEnabled) {
+      return buffer -> UnsafeByteOperations.unsafeWrap(buffer);
+    } else {
+      return buffer -> {
+        ByteString retval = ByteString.copyFrom(buffer);
+        buffer.flip();
 
 Review comment:
   Buffer.flip() will be required to reset the pos to 0, as ByteString.Copy advances the position
to the data length,
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 324135)
    Time Spent: 1h 10m  (was: 1h)

> Remove ByteStringHelper and refactor the code to the place where it used
> ------------------------------------------------------------------------
>
>                 Key: HDDS-2233
>                 URL: https://issues.apache.org/jira/browse/HDDS-2233
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Istvan Fajth
>            Priority: Critical
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> See HDDS-2203 where there is a race condition reported by me.
> Later in the discussion we agreed that it is better to refactor the code and remove the
class completely for now, and that would also resolve the race condition.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message