hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-2228) Fix NPE in OzoneDelegationTokenManager#addPersistedDelegationToken
Date Wed, 02 Oct 2019 14:49:01 GMT

     [ https://issues.apache.org/jira/browse/HDDS-2228?focusedWorklogId=321948&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321948
]

ASF GitHub Bot logged work on HDDS-2228:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Oct/19 14:48
            Start Date: 02/Oct/19 14:48
    Worklog Time Spent: 10m 
      Work Description: xiaoyuyao commented on pull request #1571: HDDS-2228. Fix NPE in OzoneDelegationTokenManager#addPersistedDelegat…
URL: https://github.com/apache/hadoop/pull/1571#discussion_r330594466
 
 

 ##########
 File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSecretManager.java
 ##########
 @@ -84,13 +84,16 @@
    * milliseconds
    * @param dtRemoverScanInterval how often the tokens are scanned for expired
    * tokens in milliseconds
+   * @param certClient certificate client to SCM CA
    */
   public OzoneDelegationTokenSecretManager(OzoneConfiguration conf,
       long tokenMaxLifetime, long tokenRenewInterval,
       long dtRemoverScanInterval, Text service,
-      S3SecretManager s3SecretManager) throws IOException {
+      S3SecretManager s3SecretManager, CertificateClient certClient)
+      throws IOException {
     super(new SecurityConfig(conf), tokenMaxLifetime, tokenRenewInterval,
         service, LOG);
+    setCertClient(certClient);
 
 Review comment:
   Thanks for the review, @bharatviswa504. My first version of this patch is like what you
mentioned above. But it introduce many unnecessary changes to another subclass for OzoneBlockTokenSecretManager,
which does not need a certClient at constructor. It also affect many tests that use a special
test flag to avoid talking to SCM for kerberos based test.
   
   The current patch makes it optional by introduce a set method for the constructor of OzoneDelegationTokenSecret
manager to use only.  This way, the change is minimized.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 321948)
    Time Spent: 40m  (was: 0.5h)

> Fix NPE in OzoneDelegationTokenManager#addPersistedDelegationToken
> ------------------------------------------------------------------
>
>                 Key: HDDS-2228
>                 URL: https://issues.apache.org/jira/browse/HDDS-2228
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>            Priority: Blocker
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The certClient was not initialized in proper order as a result, when OM restart with
delegation token issued, the ozone delegation token secret manager NPE. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message