hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-2204) Avoid buffer coping in checksum verification
Date Fri, 04 Oct 2019 10:44:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-2204?focusedWorklogId=323323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323323
]

ASF GitHub Bot logged work on HDDS-2204:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Oct/19 10:43
            Start Date: 04/Oct/19 10:43
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on issue #1593: HDDS-2204. Avoid buffer coping
in checksum verification.
URL: https://github.com/apache/hadoop/pull/1593#issuecomment-538347183
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 40 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. |
   ||| _ trunk Compile Tests _ |
   | -1 | mvninstall | 37 | hadoop-hdds in trunk failed. |
   | -1 | mvninstall | 37 | hadoop-ozone in trunk failed. |
   | -1 | compile | 22 | hadoop-hdds in trunk failed. |
   | -1 | compile | 15 | hadoop-ozone in trunk failed. |
   | +1 | checkstyle | 62 | trunk passed |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 859 | branch has no errors when building and testing our client artifacts.
|
   | -1 | javadoc | 23 | hadoop-hdds in trunk failed. |
   | -1 | javadoc | 19 | hadoop-ozone in trunk failed. |
   | 0 | spotbugs | 973 | Used deprecated FindBugs config; considering switching to SpotBugs.
|
   | -1 | findbugs | 47 | hadoop-hdds in trunk failed. |
   | -1 | findbugs | 21 | hadoop-ozone in trunk failed. |
   ||| _ Patch Compile Tests _ |
   | -1 | mvninstall | 35 | hadoop-hdds in the patch failed. |
   | -1 | mvninstall | 37 | hadoop-ozone in the patch failed. |
   | -1 | compile | 25 | hadoop-hdds in the patch failed. |
   | -1 | compile | 20 | hadoop-ozone in the patch failed. |
   | -1 | javac | 25 | hadoop-hdds in the patch failed. |
   | -1 | javac | 20 | hadoop-ozone in the patch failed. |
   | +1 | checkstyle | 57 | the patch passed |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 722 | patch has no errors when building and testing our client artifacts.
|
   | -1 | javadoc | 22 | hadoop-hdds in the patch failed. |
   | -1 | javadoc | 20 | hadoop-ozone in the patch failed. |
   | -1 | findbugs | 31 | hadoop-hdds in the patch failed. |
   | -1 | findbugs | 21 | hadoop-ozone in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 29 | hadoop-hdds in the patch failed. |
   | -1 | unit | 26 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 33 | The patch does not generate ASF License warnings. |
   | | | 2404 | |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/Dockerfile
|
   | GITHUB PR | https://github.com/apache/hadoop/pull/1593 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient
findbugs checkstyle |
   | uname | Linux 8b31ae32a557 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019
x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 4cf0b36 |
   | Default Java | 1.8.0_222 |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
|
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/branch-compile-hadoop-hdds.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/branch-compile-hadoop-ozone.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/branch-javadoc-hadoop-hdds.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/branch-javadoc-hadoop-ozone.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/branch-findbugs-hadoop-hdds.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/branch-findbugs-hadoop-ozone.txt
|
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
|
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-compile-hadoop-hdds.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-compile-hadoop-ozone.txt
|
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-compile-hadoop-hdds.txt
|
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-compile-hadoop-ozone.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-javadoc-hadoop-hdds.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-javadoc-hadoop-ozone.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-findbugs-hadoop-hdds.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-findbugs-hadoop-ozone.txt
|
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-unit-hadoop-hdds.txt
|
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/artifact/out/patch-unit-hadoop-ozone.txt
|
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/testReport/
|
   | Max. process+thread count | 412 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdds/common U: hadoop-hdds/common |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1593/1/console
|
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 323323)
    Time Spent: 20m  (was: 10m)

> Avoid buffer coping in checksum verification
> --------------------------------------------
>
>                 Key: HDDS-2204
>                 URL: https://issues.apache.org/jira/browse/HDDS-2204
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Client
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: o2204_20190930.patch, o2204_20190930b.patch, o2204_20191001.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In Checksum.verifyChecksum(ByteString, ..), it first converts the ByteString to a byte
array.  It lead to an unnecessary buffer coping.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message