hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1986) Fix listkeys API
Date Thu, 10 Oct 2019 02:50:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1986?focusedWorklogId=326082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326082

ASF GitHub Bot logged work on HDDS-1986:

                Author: ASF GitHub Bot
            Created on: 10/Oct/19 02:49
            Start Date: 10/Oct/19 02:49
    Worklog Time Spent: 10m 
      Work Description: arp7 commented on pull request #1588: HDDS-1986. Fix listkeys API.
URL: https://github.com/apache/hadoop/pull/1588#discussion_r333310356

 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
 @@ -645,7 +648,12 @@ public boolean isBucketEmpty(String volume, String bucket)
   public List<OmKeyInfo> listKeys(String volumeName, String bucketName,
       String startKey, String keyPrefix, int maxKeys) throws IOException {
     List<OmKeyInfo> result = new ArrayList<>();
+    if (maxKeys == 0) {
 Review comment:
   Yeah that would be a nice bit of defensive programming. Let's make the check `<= 0`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 326082)
    Time Spent: 2h 40m  (was: 2.5h)

> Fix listkeys API
> ----------------
>                 Key: HDDS-1986
>                 URL: https://issues.apache.org/jira/browse/HDDS-1986
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
> This Jira is to fix listKeys API in HA code path.
> In HA, we have an in-memory cache, where we put the result to in-memory cache and return
the response, later it will be picked by double buffer thread and it will flush to disk. So,
now when do listkeys, it should use both in-memory cache and rocksdb key table to list keys
in a bucket.

This message was sent by Atlassian Jira

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message