hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Antal (Jira)" <j...@apache.org>
Subject [jira] [Moved] (HDFS-14897) [hadoop-hdfs] Fix order of actual and expected expression in assert statements
Date Mon, 07 Oct 2019 08:35:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-14897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Adam Antal moved HADOOP-16511 to HDFS-14897:
--------------------------------------------

                  Key: HDFS-14897  (was: HADOOP-16511)
     Target Version/s: 3.3.0  (was: 3.3.0)
    Affects Version/s:     (was: 3.2.0)
                       3.2.0
              Project: Hadoop HDFS  (was: Hadoop Common)

> [hadoop-hdfs] Fix order of actual and expected expression in assert statements
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-14897
>                 URL: https://issues.apache.org/jira/browse/HDFS-14897
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.2.0
>            Reporter: Adam Antal
>            Priority: Major
>
> Fix order of actual and expected expression in assert statements which gives misleading
message when test case fails. Attached file has some of the places where it is placed wrongly.
> {code:java}
> [ERROR] testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
 Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be used for new
test cases which avoids such mistakes.
> This is a follow-up jira for the hadoop-hdfs project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message