hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1737) Add Volume check in KeyManager and File Operations
Date Wed, 09 Oct 2019 17:53:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1737?focusedWorklogId=325847&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325847
]

ASF GitHub Bot logged work on HDDS-1737:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Oct/19 17:52
            Start Date: 09/Oct/19 17:52
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on pull request #1559: HDDS-1737. Add Volume
check in KeyManager and File Operations.
URL: https://github.com/apache/hadoop/pull/1559#discussion_r333148592
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRenameRequest.java
 ##########
 @@ -123,10 +125,15 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
       acquiredLock = omMetadataManager.getLock().acquireLock(BUCKET_LOCK,
           volumeName, bucketName);
 
-      // Not doing bucket/volume checks here. In this way we can avoid db
-      // checks for them.
-      // TODO: Once we have volume/bucket full cache, we can add
-      // them back, as these checks will be inexpensive at that time.
+      // Check bucket/volume exist.
+      String volumeKey = omMetadataManager.getVolumeKey(volumeName);
+      String bucketKey = omMetadataManager.getBucketKey(volumeName, bucketName);
+      if (!omMetadataManager.getBucketTable().isExist(bucketKey)) {
 
 Review comment:
   We can move this to a base class method, which can be used in all classes.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 325847)
    Time Spent: 2h 40m  (was: 2.5h)

> Add Volume check in KeyManager and File Operations
> --------------------------------------------------
>
>                 Key: HDDS-1737
>                 URL: https://issues.apache.org/jira/browse/HDDS-1737
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: YiSheng Lien
>            Priority: Major
>              Labels: newbie, pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> This is to address a TODO to check volume checks when performing Key/File operations.
>  
> // TODO: Not checking volume exist here, once we have full cache we can
> // add volume exist check also.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message