hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HaiBin Huang (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14612) SlowDiskReport won't update when SlowDisks is always empty in heartbeat
Date Fri, 11 Oct 2019 02:47:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949074#comment-16949074
] 

HaiBin Huang commented on HDFS-14612:
-------------------------------------

update patch v2, add a new test

> SlowDiskReport won't update when SlowDisks is always empty in heartbeat
> -----------------------------------------------------------------------
>
>                 Key: HDFS-14612
>                 URL: https://issues.apache.org/jira/browse/HDFS-14612
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: HaiBin Huang
>            Assignee: HaiBin Huang
>            Priority: Major
>         Attachments: HDFS-14612-001.patch, HDFS-14612-002.patch, HDFS-14612.patch
>
>
> I found SlowDiskReport won't update when slowDisks is always empty in org.apache.hadoop.hdfs.server.blockmanagement.*handleHeartbeat*,
this may lead to outdated SlowDiskReport alway staying in jmx of namenode until next time slowDisks
isn't empty. So i think this method *checkAndUpdateReportIfNecessary()* should be called
firstly when we want to get the jmx information about SlowDiskReport, this can keep the SlowDiskReport
on jmx is alway valid.
>  
> There is also some incorrect object reference on org.apache.hadoop.hdfs.server.datanode.fsdataset.
> *DataNodeVolumeMetrics*
> {code:java}
> // Based on writeIoRate
> public long getWriteIoSampleCount() {
>   return syncIoRate.lastStat().numSamples();
> }
> public double getWriteIoMean() {
>   return syncIoRate.lastStat().mean();
> }
> public double getWriteIoStdDev() {
>   return syncIoRate.lastStat().stddev();
> }
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message