From hdfs-issues-return-284888-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Sep 24 16:59:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2F2E5180644 for ; Tue, 24 Sep 2019 18:59:03 +0200 (CEST) Received: (qmail 34041 invoked by uid 500); 24 Sep 2019 16:59:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 34030 invoked by uid 99); 24 Sep 2019 16:59:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Sep 2019 16:59:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 27C3EE3138 for ; Tue, 24 Sep 2019 16:59:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 296677807DA for ; Tue, 24 Sep 2019 16:59:00 +0000 (UTC) Date: Tue, 24 Sep 2019 16:59:00 +0000 (UTC) From: =?utf-8?Q?=C3=8D=C3=B1igo_Goiri_=28Jira=29?= To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-14843) Double Synchronization in BlockReportLeaseManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-14843?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] =C3=8D=C3=B1igo Goiri updated HDFS-14843: ------------------------------- Fix Version/s: 3.3.0 Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) > Double Synchronization in BlockReportLeaseManager > ------------------------------------------------- > > Key: HDFS-14843 > URL: https://issues.apache.org/jira/browse/HDFS-14843 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Fix For: 3.3.0 > > Attachments: HDFS-14843.1.patch > > > {code:java|title=3DBlockReportLeaseManager.java} > private synchronized long getNextId() { > long id; > do { > id =3D nextId++; > } while (id =3D=3D 0); > return id; > } > {code} > This is a private method and is synchronized, however, it is only be acce= ssed from an already-synchronized method. No need to double-synchronize. > https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hd= fs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockReportL= easeManager.java#L183-L189 > https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hd= fs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockReportL= easeManager.java#L227 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org