hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object
Date Wed, 25 Sep 2019 22:14:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=318626&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318626
]

ASF GitHub Bot logged work on HDDS-2180:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Sep/19 22:13
            Start Date: 25/Sep/19 22:13
    Worklog Time Spent: 10m 
      Work Description: anuengineer commented on pull request #1526: HDDS-2180. Add Object
ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#discussion_r328362976
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeRequest.java
 ##########
 @@ -95,13 +100,18 @@ protected VolumeList addVolumeToOwnerList(VolumeList volumeList,
     }
 
     List<String> prevVolList = new ArrayList<>();
+    long objectID = 100;
     if (volumeList != null) {
       prevVolList.addAll(volumeList.getVolumeNamesList());
+      objectID = volumeList.getObjectID();
 
 Review comment:
   Yes, for some reason, when we replace a VolumeList, we do it like this. We read the current
list, remove or add a new volume, create a new object and then write it back. This is reality
nothing but a small change in the list of volumes. So I keep the same object ID as if Object
is same.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 318626)
    Time Spent: 50m  (was: 40m)

> Add Object ID and update ID on VolumeList Object
> ------------------------------------------------
>
>                 Key: HDDS-2180
>                 URL: https://issues.apache.org/jira/browse/HDDS-2180
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message