hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-2166) Some RPC metrics are missing from SCM prometheus endpoint
Date Fri, 27 Sep 2019 10:30:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-2166?focusedWorklogId=319477&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319477
]

ASF GitHub Bot logged work on HDDS-2166:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Sep/19 10:29
            Start Date: 27/Sep/19 10:29
    Worklog Time Spent: 10m 
      Work Description: elek commented on issue #1505: HDDS-2166. Some RPC metrics are missing
from SCM prometheus endpoint
URL: https://github.com/apache/hadoop/pull/1505#issuecomment-535885148
 
 
   Thanks @xiaoyuyao the review. I will commit it after a new jenkins build.
   
   Debug System.out.println is removed (from the patch and also from the previous method).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 319477)
    Time Spent: 1h 10m  (was: 1h)

> Some RPC metrics are missing from SCM prometheus endpoint
> ---------------------------------------------------------
>
>                 Key: HDDS-2166
>                 URL: https://issues.apache.org/jira/browse/HDDS-2166
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Marton Elek
>            Assignee: Marton Elek
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In Hadoop metrics it's possible to register multiple metrics with the same name but with
different tags. For example each RpcServere has an own metrics instance in SCM.
> {code}
>     "name" : "Hadoop:service=StorageContainerManager,name=RpcActivityForPort9860",
>     "name" : "Hadoop:service=StorageContainerManager,name=RpcActivityForPort9863",
> {code}
> They are converted by PrometheusSink to a prometheus metric line with proper name and
tags. For example:
> {code}
> rpc_rpc_queue_time60s_num_ops{port="9860",servername="StorageContainerLocationProtocolService",context="rpc",hostname="72736061cbc5"}
0
> {code}
> The PrometheusSink uses a Map to cache all the recent values but unfortunately the key
contains only the name (rpc_rpc_queue_time60s_num_ops in our example) but not the tags (port=...)
> For this reason if there are multiple metrics with the same name, only the first one
will be displayed.
> As a result in SCM only the metrics of the first RPC server can be exported to the prometheus
endpoint. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message