hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-2159) Fix Race condition in ProfileServlet#pid
Date Sat, 21 Sep 2019 00:35:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-2159?focusedWorklogId=316006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316006
]

ASF GitHub Bot logged work on HDDS-2159:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/19 00:34
            Start Date: 21/Sep/19 00:34
    Worklog Time Spent: 10m 
      Work Description: xiaoyuyao commented on pull request #1488: HDDS-2159. Fix Race condition
in ProfileServlet#pid.
URL: https://github.com/apache/hadoop/pull/1488#discussion_r326838670
 
 

 ##########
 File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/ProfileServlet.java
 ##########
 @@ -208,11 +208,11 @@ protected void doGet(final HttpServletRequest req,
       return;
     }
     // if pid is explicitly specified, use it else default to current process
-    pid = getInteger(req, "pid", pid);
+    Integer processId = getInteger(req, "pid", pid);
 
     // if pid is not specified in query param and if current process pid
 
 Review comment:
   should we update the comment? It seems we are not trying to determine current process pid?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 316006)
    Time Spent: 0.5h  (was: 20m)

> Fix Race condition in ProfileServlet#pid
> ----------------------------------------
>
>                 Key: HDDS-2159
>                 URL: https://issues.apache.org/jira/browse/HDDS-2159
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There is a race condition in ProfileServlet. The Servlet member field pid should not
be used for local assignment. It could lead to race condition.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message