hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-2067) Create generic service facade with tracing/metrics/logging support
Date Wed, 25 Sep 2019 09:57:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-2067?focusedWorklogId=318194&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318194
]

ASF GitHub Bot logged work on HDDS-2067:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Sep/19 09:56
            Start Date: 25/Sep/19 09:56
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on issue #1501: HDDS-2067. Create generic service
facade with tracing/metrics/logging support
URL: https://github.com/apache/hadoop/pull/1501#issuecomment-534947115
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 41 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 66 | Maven dependency ordering for branch |
   | -1 | mvninstall | 31 | hadoop-hdds in trunk failed. |
   | -1 | mvninstall | 25 | hadoop-ozone in trunk failed. |
   | -1 | compile | 20 | hadoop-hdds in trunk failed. |
   | -1 | compile | 13 | hadoop-ozone in trunk failed. |
   | +1 | checkstyle | 50 | trunk passed |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 917 | branch has no errors when building and testing our client artifacts.
|
   | -1 | javadoc | 18 | hadoop-hdds in trunk failed. |
   | -1 | javadoc | 16 | hadoop-ozone in trunk failed. |
   | 0 | spotbugs | 1001 | Used deprecated FindBugs config; considering switching to SpotBugs.
|
   | -1 | findbugs | 29 | hadoop-hdds in trunk failed. |
   | -1 | findbugs | 17 | hadoop-ozone in trunk failed. |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 28 | Maven dependency ordering for patch |
   | -1 | mvninstall | 32 | hadoop-hdds in the patch failed. |
   | -1 | mvninstall | 27 | hadoop-ozone in the patch failed. |
   | -1 | compile | 19 | hadoop-hdds in the patch failed. |
   | -1 | compile | 16 | hadoop-ozone in the patch failed. |
   | -1 | javac | 19 | hadoop-hdds in the patch failed. |
   | -1 | javac | 16 | hadoop-ozone in the patch failed. |
   | +1 | checkstyle | 55 | the patch passed |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 801 | patch has no errors when building and testing our client artifacts.
|
   | -1 | javadoc | 17 | hadoop-hdds in the patch failed. |
   | -1 | javadoc | 16 | hadoop-ozone in the patch failed. |
   | -1 | findbugs | 27 | hadoop-hdds in the patch failed. |
   | -1 | findbugs | 16 | hadoop-ozone in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 23 | hadoop-hdds in the patch failed. |
   | -1 | unit | 20 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 29 | The patch does not generate ASF License warnings. |
   | | | 2492 | |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/Dockerfile
|
   | GITHUB PR | https://github.com/apache/hadoop/pull/1501 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient
findbugs checkstyle |
   | uname | Linux 3df5fd126fd3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019
x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / c724577 |
   | Default Java | 1.8.0_222 |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/branch-mvninstall-hadoop-hdds.txt
|
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/branch-mvninstall-hadoop-ozone.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/branch-compile-hadoop-hdds.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/branch-compile-hadoop-ozone.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/branch-javadoc-hadoop-hdds.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/branch-javadoc-hadoop-ozone.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/branch-findbugs-hadoop-hdds.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/branch-findbugs-hadoop-ozone.txt
|
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-mvninstall-hadoop-hdds.txt
|
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-mvninstall-hadoop-ozone.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-compile-hadoop-hdds.txt
|
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-compile-hadoop-ozone.txt
|
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-compile-hadoop-hdds.txt
|
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-compile-hadoop-ozone.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-javadoc-hadoop-hdds.txt
|
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-javadoc-hadoop-ozone.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-findbugs-hadoop-hdds.txt
|
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-findbugs-hadoop-ozone.txt
|
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-unit-hadoop-hdds.txt
|
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/artifact/out/patch-unit-hadoop-ozone.txt
|
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/testReport/
|
   | Max. process+thread count | 306 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdds/common hadoop-hdds/framework hadoop-hdds/server-scm hadoop-ozone/insight
hadoop-ozone/ozone-manager U: . |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1501/4/console
|
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 318194)
    Time Spent: 1h 50m  (was: 1h 40m)

> Create generic service facade with tracing/metrics/logging support
> ------------------------------------------------------------------
>
>                 Key: HDDS-2067
>                 URL: https://issues.apache.org/jira/browse/HDDS-2067
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> We started to use a message based GRPC approach. Wen have only one method and the requests
are routed based on a "type" field in the proto message. 
> For example in OM protocol:
> {code}
> /**
>  The OM service that takes care of Ozone namespace.
> */
> service OzoneManagerService {
>     // A client-to-OM RPC to send client requests to OM Ratis server
>     rpc submitRequest(OMRequest)
>           returns(OMResponse);
> }
> {code}
> And 
> {code}
> message OMRequest {
>   required Type cmdType = 1; // Type of the command
> ...
> {code}
> This approach makes it possible to use the same code to process incoming messages in
the server side.
> ScmBlockLocationProtocolServerSideTranslatorPB.send method contains the logic of:
>  * Logging the request/response message (can be displayed with ozone insight)
>  * Updated metrics
>  * Handle open tracing context propagation.
> These functions are generic. For example OzoneManagerProtocolServerSideTranslatorPB use
the same (=similar) code.
> The goal in this jira is to provide a generic utility and move the common code for tracing/request
logging/response logging/metrics calculation to a common utility which can be used from all
the ServerSide translators.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message