hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1982) Extend SCMNodeManager to support decommission and maintenance states
Date Thu, 05 Sep 2019 11:19:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1982?focusedWorklogId=307079&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307079
]

ASF GitHub Bot logged work on HDDS-1982:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Sep/19 11:18
            Start Date: 05/Sep/19 11:18
    Worklog Time Spent: 10m 
      Work Description: sodonnel commented on pull request #1344: HDDS-1982 Extend SCMNodeManager
to support decommission and maintenance states
URL: https://github.com/apache/hadoop/pull/1344#discussion_r321204004
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
 ##########
 @@ -185,7 +190,7 @@ public int getNodeCount(NodeState nodestate) {
   @Override
   public NodeState getNodeState(DatanodeDetails datanodeDetails) {
 
 Review comment:
   Yes, the 'external interface' of SCMNodeManager will need to change but I want to get these
changes to be good internally before we push them up the stack.
   
   Thanks for taking the time to review this WIP. Glad to hear this is going in the correct
direction so I will look to tidy things up and then we can consider the next step.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 307079)
    Time Spent: 2h 40m  (was: 2.5h)

> Extend SCMNodeManager to support decommission and maintenance states
> --------------------------------------------------------------------
>
>                 Key: HDDS-1982
>                 URL: https://issues.apache.org/jira/browse/HDDS-1982
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: SCM
>            Reporter: Stephen O'Donnell
>            Assignee: Stephen O'Donnell
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Currently, within SCM a node can have the following states:
> HEALTHY
> STALE
> DEAD
> DECOMMISSIONING
> DECOMMISSIONED
> The last 2 are not currently used.
> In order to support decommissioning and maintenance mode, we need to extend the set of
states a node can have to include decommission and maintenance states.
> It is also important to note that a node decommissioning or entering maintenance can
also be HEALTHY, STALE or go DEAD.
> Therefore in this Jira I propose we should model a node state with two different sets
of values. The first, is effectively the liveliness of the node, with the following states.
This is largely what is in place now:
> HEALTHY
> STALE
> DEAD
> The second is the node operational state:
> IN_SERVICE
> DECOMMISSIONING
> DECOMMISSIONED
> ENTERING_MAINTENANCE
> IN_MAINTENANCE
> That means the overall total number of states for a node is the cross-product of the
two above lists, however it probably makes sense to keep the two states seperate internally.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message