hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1982) Extend SCMNodeManager to support decommission and maintenance states
Date Fri, 06 Sep 2019 07:56:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1982?focusedWorklogId=307688&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307688
]

ASF GitHub Bot logged work on HDDS-1982:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Sep/19 07:55
            Start Date: 06/Sep/19 07:55
    Worklog Time Spent: 10m 
      Work Description: sodonnel commented on pull request #1344: HDDS-1982 Extend SCMNodeManager
to support decommission and maintenance states
URL: https://github.com/apache/hadoop/pull/1344#discussion_r321616777
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/states/NodeStateMap.java
 ##########
 @@ -43,7 +45,7 @@
   /**
    * Represents the current state of node.
    */
-  private final ConcurrentHashMap<NodeState, Set<UUID>> stateMap;
+  private final ConcurrentHashMap<UUID, NodeStatus> stateMap;
 
 Review comment:
   Do you think it makes sense to have a field inside DatanodeInfo of type NodeStatus, so
we can always pass the states around as a pair, or should we add two individual fields to
DatanodeInfo - nodeHealth and nodeOperationalState?
   
   Also, one other thing to consider, is nodeStateMap originally kept a list of healthy, stale
and dead, so it was possible to quickly return all nodes in that state. However now, we need
to iterate over the whole list to find those nodes. One reason for this, is that we have 15
different states now instead of 3. If we move nodeStatus into datanodeInfo, it would be more
difficult to optimise this later if needed. However it would simplify things if we simply
remove this stateMap.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 307688)
    Time Spent: 3h 40m  (was: 3.5h)

> Extend SCMNodeManager to support decommission and maintenance states
> --------------------------------------------------------------------
>
>                 Key: HDDS-1982
>                 URL: https://issues.apache.org/jira/browse/HDDS-1982
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: SCM
>            Reporter: Stephen O'Donnell
>            Assignee: Stephen O'Donnell
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Currently, within SCM a node can have the following states:
> HEALTHY
> STALE
> DEAD
> DECOMMISSIONING
> DECOMMISSIONED
> The last 2 are not currently used.
> In order to support decommissioning and maintenance mode, we need to extend the set of
states a node can have to include decommission and maintenance states.
> It is also important to note that a node decommissioning or entering maintenance can
also be HEALTHY, STALE or go DEAD.
> Therefore in this Jira I propose we should model a node state with two different sets
of values. The first, is effectively the liveliness of the node, with the following states.
This is largely what is in place now:
> HEALTHY
> STALE
> DEAD
> The second is the node operational state:
> IN_SERVICE
> DECOMMISSIONING
> DECOMMISSIONED
> ENTERING_MAINTENANCE
> IN_MAINTENANCE
> That means the overall total number of states for a node is the cross-product of the
two above lists, however it probably makes sense to keep the two states seperate internally.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message