From hdfs-issues-return-280370-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Aug 28 00:47:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3BBBE180654 for ; Wed, 28 Aug 2019 02:47:02 +0200 (CEST) Received: (qmail 44466 invoked by uid 500); 28 Aug 2019 00:47:01 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 44448 invoked by uid 99); 28 Aug 2019 00:47:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Aug 2019 00:47:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D2BCAE2FE5 for ; Wed, 28 Aug 2019 00:47:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 5004B78225B for ; Wed, 28 Aug 2019 00:47:00 +0000 (UTC) Date: Wed, 28 Aug 2019 00:47:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HDDS-2045) Partially started compose cluster left running MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-2045?focusedWorklogId=302483&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302483 ] ASF GitHub Bot logged work on HDDS-2045: ---------------------------------------- Author: ASF GitHub Bot Created on: 28/Aug/19 00:46 Start Date: 28/Aug/19 00:46 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #1358: HDDS-2045. Partially started compose cluster left running URL: https://github.com/apache/hadoop/pull/1358#discussion_r318352730 ########## File path: hadoop-ozone/dist/src/main/compose/testlib.sh ########## @@ -82,9 +82,14 @@ start_docker_env(){ local -i datanode_count=${1:-3} docker-compose -f "$COMPOSE_FILE" down - docker-compose -f "$COMPOSE_FILE" up -d --scale datanode="${datanode_count}" - wait_for_datanodes "$COMPOSE_FILE" "${datanode_count}" - sleep 10 + docker-compose -f "$COMPOSE_FILE" up -d --scale datanode="${datanode_count}" \ + && wait_for_datanodes "$COMPOSE_FILE" "${datanode_count}" \ + && sleep 10 + + if [[ $? -gt 0 ]]; then Review comment: shellcheck:9: note: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. [SC2181] ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 302483) Time Spent: 0.5h (was: 20m) > Partially started compose cluster left running > ---------------------------------------------- > > Key: HDDS-2045 > URL: https://issues.apache.org/jira/browse/HDDS-2045 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: docker, test > Reporter: Doroszlai, Attila > Assignee: Doroszlai, Attila > Priority: Minor > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > If any container in the sample cluster [fails to start|https://github.com/elek/ozone-ci/blob/5c64f77f3ab64aed0826d8f40991fe621f843efd/pr/pr-hdds-2026-p4f6m/acceptance/output.log#L24], all successfully started containers are left running. This [prevents|https://github.com/elek/ozone-ci/blob/5c64f77f3ab64aed0826d8f40991fe621f843efd/pr/pr-hdds-2026-p4f6m/acceptance/output.log#L59] any further acceptance tests from normal completion. This is only a minor inconvenience, since acceptance test as a whole fails either way. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org