From hdfs-issues-return-278725-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Aug 21 01:23:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4E8E818063F for ; Wed, 21 Aug 2019 03:23:02 +0200 (CEST) Received: (qmail 74747 invoked by uid 500); 21 Aug 2019 01:23:01 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 74735 invoked by uid 99); 21 Aug 2019 01:23:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Aug 2019 01:23:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DB5D5E300B for ; Wed, 21 Aug 2019 01:23:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 58C3B780C5C for ; Wed, 21 Aug 2019 01:23:00 +0000 (UTC) Date: Wed, 21 Aug 2019 01:23:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HDDS-1927) Consolidate add/remove Acl into OzoneAclUtil class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-1927?focusedWorklogId=3D2= 98356&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-298356 ] ASF GitHub Bot logged work on HDDS-1927: ---------------------------------------- Author: ASF GitHub Bot Created on: 21/Aug/19 01:22 Start Date: 21/Aug/19 01:22 Worklog Time Spent: 10m=20 Work Description: xiaoyuyao commented on issue #1263: HDDS-1927. Cons= olidate add/remove Acl into OzoneAclUtil class. Contri=E2=80=A6 URL: https://github.com/apache/hadoop/pull/1263#issuecomment-523256372 =20 =20 /retest =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 298356) Time Spent: 7.5h (was: 7h 20m) > Consolidate add/remove Acl into OzoneAclUtil class > -------------------------------------------------- > > Key: HDDS-1927 > URL: https://issues.apache.org/jira/browse/HDDS-1927 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Bharat Viswanadham > Assignee: Xiaoyu Yao > Priority: Major > Labels: pull-request-available > Time Spent: 7.5h > Remaining Estimate: 0h > > This Jira is created based on @xiaoyu comment on HDDS-1884 > Can we abstract these add/remove logic into common AclUtil class as we ca= n see similar logic in both bucket manager and key manager? For example, > public static boolean addAcl(List existingAcls, OzoneAcl newAcl) > public static boolean removeAcl(List existingAcls, OzoneAcl newAcl) > =C2=A0 > But to do this, we need both OmKeyInfo and OMBucketInfo to use list of Oz= oneAcl/OzoneAclInfo. > This Jira is to do that refactor, and also address above comment to move = common logic to AclUtils. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org