From hdfs-issues-return-281140-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Aug 30 17:22:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 09C9418065E for ; Fri, 30 Aug 2019 19:22:02 +0200 (CEST) Received: (qmail 58566 invoked by uid 500); 30 Aug 2019 17:22:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 58553 invoked by uid 99); 30 Aug 2019 17:22:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Aug 2019 17:22:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9E3A2E3097 for ; Fri, 30 Aug 2019 17:22:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 6BCAB7809A2 for ; Fri, 30 Aug 2019 17:22:00 +0000 (UTC) Date: Fri, 30 Aug 2019 17:22:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HDDS-1879) Support multiple excluded scopes when choosing datanodes in NetworkTopology MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-1879?focusedWorklogId=304410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304410 ] ASF GitHub Bot logged work on HDDS-1879: ---------------------------------------- Author: ASF GitHub Bot Created on: 30/Aug/19 17:21 Start Date: 30/Aug/19 17:21 Worklog Time Spent: 10m Work Description: xiaoyuyao commented on pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology URL: https://github.com/apache/hadoop/pull/1194#discussion_r319605573 ########## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/InnerNodeImpl.java ########## @@ -313,12 +314,12 @@ public Node getLeaf(int leafIndex) { * means picking the 3th available node, which is n5. Review comment: It is not related to the current change. But the example in the comments need further clarification. E.g., n5 is under /dc2 which is in excludedScope. Maybe you want to put n5 under /root/dc1/rack2? instead of /root/dc2/rack1? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 304410) Time Spent: 1.5h (was: 1h 20m) > Support multiple excluded scopes when choosing datanodes in NetworkTopology > --------------------------------------------------------------------------- > > Key: HDDS-1879 > URL: https://issues.apache.org/jira/browse/HDDS-1879 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Sammi Chen > Assignee: Sammi Chen > Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org