From hdfs-issues-return-279350-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Aug 22 20:30:07 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D709D180644 for ; Thu, 22 Aug 2019 22:30:06 +0200 (CEST) Received: (qmail 38132 invoked by uid 500); 22 Aug 2019 20:30:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 37971 invoked by uid 99); 22 Aug 2019 20:30:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Aug 2019 20:30:03 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 25CDAE3077 for ; Thu, 22 Aug 2019 20:30:03 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id BBF2978229B for ; Thu, 22 Aug 2019 20:30:00 +0000 (UTC) Date: Thu, 22 Aug 2019 20:30:00 +0000 (UTC) From: "Hadoop QA (Jira)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13321) Inadequate information for handling catch clauses MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13321?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1691= 3676#comment-16913676 ]=20 Hadoop QA commented on HDFS-13321: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 42s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0= m 1s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m = 0s{color} | {color:red} The patch doesn't appear to include any new or modi= fied tests. Please justify why no new tests are needed for this patch. Also= please list what manual steps were performed to verify this patch. {color}= | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 17m 37s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 18= m 49s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 2m 15s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3= m 53s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 17m 32s{color} | {color:green} branch has no errors when building and te= sting our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3= m 6s{color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m 3= 6s{color} | {color:blue} Used deprecated FindBugs config; considering switc= hing to SpotBugs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 7m 45s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 3m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 16= m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 16m = 21s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:oran= ge} 2m 14s{color} | {color:orange} root: The patch generated 2 new + 47 un= changed - 0 fixed =3D 49 total (was 47) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4= m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 10m 34s{color} | {color:green} patch has no errors when building and tes= ting our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3= m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 8m 17s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m 4= 7s{color} | {color:green} hadoop-common in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 80m 32s{col= or} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 20m 5= 9s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passe= d. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m 2= 2s{color} | {color:green} hadoop-mapreduce-client-core in the patch passed.= {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 2= 6s{color} | {color:green} hadoop-aliyun in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 47s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}235m 48s{colo= r} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.datanode.TestDataNodeUUID | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D19.03.1 Server=3D19.03.1 base: https://builds.apache.or= g/job/hadoop-multibranch/job/PR-357/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/357 | | JIRA Issue | HDFS-13321 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvns= ite unit shadedclient findbugs checkstyle | | uname | Linux 16f73f85fba2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17= :16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 61b2df2 | | Default Java | 1.8.0_212 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-357/= 7/artifact/out/diff-checkstyle-root.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-357/7/arti= fact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-3= 57/7/testReport/ | | Max. process+thread count | 4128 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hado= op-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-serv= er-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapr= educe-client-core hadoop-tools/hadoop-aliyun U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-= 357/7/console | | versions | git=3D2.7.4 maven=3D3.3.9 findbugs=3D3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. > Inadequate information for handling catch clauses > ------------------------------------------------- > > Key: HDFS-13321 > URL: https://issues.apache.org/jira/browse/HDFS-13321 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Affects Versions: 3.0.0 > Reporter: Zhenhao Li > Priority: Major > Labels: easyfix > > Their are some situations that different exception types are caught, but = the handling of those exceptions can not show the differences of those type= s. Here are the code snippets we found which have this problem: > *hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServi= ceActor.java* > [https://github.com/apache/hadoop/blob/bec79ca2495abdc347d64628151c90f5ce= 777046/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs= /server/datanode/BPServiceActor.java] > At Line=C2=A0*233*=C2=A0and Line=C2=A0*235.*=C2=A0We can see that two exc= eption types are caught, but the logging statements=C2=A0here=C2=A0can not = show the exception type at all. > Also there are comments for these two catch clauses respectively, one is = "{color:#707070}// namenode is busy{color}", the other one is "{color:#7070= 70}// namenode is not available",{color:#333333} but the log messages are t= oo generic, can not show the "busy" or "not available" of namenode.{color}{= color} > It may cause confusions to the person who=C2=A0is reading the log, the pe= rson can not know what exception happened here and can not distinguish logs= generated by these two statements. > =C2=A0Maybe adding stack trace information to these two=C2=A0logging stat= ements and change the log message to handle specific situations is a simple= way to improve it. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org