hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Mollitor (Jira)" <j...@apache.org>
Subject [jira] [Created] (HDFS-14798) Synchronize invalidateBlocks in DatanodeDescriptor
Date Thu, 29 Aug 2019 16:26:00 GMT
David Mollitor created HDFS-14798:
-------------------------------------

             Summary: Synchronize invalidateBlocks in DatanodeDescriptor
                 Key: HDFS-14798
                 URL: https://issues.apache.org/jira/browse/HDFS-14798
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: namenode
    Affects Versions: 3.2.0
            Reporter: David Mollitor


{code:java|title=DatanodeDescriptor.java}
public void resetBlocks() {
  ...
  this.invalidateBlocks.clear();
  ...
}

public void clearBlockQueues() {
  synchronized (invalidateBlocks) {
    this.invalidateBlocks.clear();
  }
  ...
}
{code}
It may not be strictly necessary, but why risk it? The invalidateBlocks should be protected
in {{resetBlocks()}} just like it is in {{clearBlockQueues()}}/



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message