hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-2045) Partially started compose cluster left running
Date Wed, 28 Aug 2019 00:47:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-2045?focusedWorklogId=302483&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302483
]

ASF GitHub Bot logged work on HDDS-2045:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Aug/19 00:46
            Start Date: 28/Aug/19 00:46
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on pull request #1358: HDDS-2045. Partially
started compose cluster left running
URL: https://github.com/apache/hadoop/pull/1358#discussion_r318352730
 
 

 ##########
 File path: hadoop-ozone/dist/src/main/compose/testlib.sh
 ##########
 @@ -82,9 +82,14 @@ start_docker_env(){
   local -i datanode_count=${1:-3}
 
   docker-compose -f "$COMPOSE_FILE" down
-  docker-compose -f "$COMPOSE_FILE" up -d --scale datanode="${datanode_count}"
-  wait_for_datanodes "$COMPOSE_FILE" "${datanode_count}"
-  sleep 10
+  docker-compose -f "$COMPOSE_FILE" up -d --scale datanode="${datanode_count}" \
+    && wait_for_datanodes "$COMPOSE_FILE" "${datanode_count}" \
+    && sleep 10
+
+  if [[ $? -gt 0 ]]; then
 
 Review comment:
   shellcheck:9: note: Check exit code directly with e.g. 'if mycmd;', not indirectly with
$?. [SC2181]
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 302483)
    Time Spent: 0.5h  (was: 20m)

> Partially started compose cluster left running
> ----------------------------------------------
>
>                 Key: HDDS-2045
>                 URL: https://issues.apache.org/jira/browse/HDDS-2045
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: docker, test
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> If any container in the sample cluster [fails to start|https://github.com/elek/ozone-ci/blob/5c64f77f3ab64aed0826d8f40991fe621f843efd/pr/pr-hdds-2026-p4f6m/acceptance/output.log#L24],
all successfully started containers are left running.  This [prevents|https://github.com/elek/ozone-ci/blob/5c64f77f3ab64aed0826d8f40991fe621f843efd/pr/pr-hdds-2026-p4f6m/acceptance/output.log#L59]
any further acceptance tests from normal completion.  This is only a minor inconvenience,
since acceptance test as a whole fails either way.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message