hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (Jira) <j...@apache.org>
Subject [jira] [Commented] (HDFS-14747) RBF: IsFileClosed should be return false when the file is open in multiple destination
Date Tue, 20 Aug 2019 16:22:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911514#comment-16911514
] 

Íñigo Goiri commented on HDFS-14747:
------------------------------------

I would do them separately, eahc one has a proper unit test for coverage so we are better
this way.
For the test, I'm not very keen on having a test that succeeds through 2 different paths;
it should either assert false or check the exception, not both.

> RBF: IsFileClosed should be return false when the file is open in multiple destination
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-14747
>                 URL: https://issues.apache.org/jira/browse/HDFS-14747
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: rbf
>            Reporter: xuzq
>            Assignee: xuzq
>            Priority: Major
>         Attachments: HDFS-14747-trunk-001.patch
>
>
> *IsFileClosed* should be return false when the file is open or be writing in multiple
destinations.
> Liks this:
> Mount point has multiple destination(ns0 and ns1).
> And the file is in ns0 but it is be writing, ns1 doesn't has this file.
> In this case *IsFileClosed* should return false instead of throw FileNotFoundException.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message