hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "xuzq (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14721) RBF: ProxyOpComplete is not accurate in FederationRPCPerformanceMonitor
Date Tue, 13 Aug 2019 02:19:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905742#comment-16905742
] 

xuzq commented on HDFS-14721:
-----------------------------

Thanks [~elgoiri]. And I will modify the unit test code.
{quote}Shouldn't we unwrapping the exception in the unknown exception case too?
{quote} * If the exception is RemoteException, it will be unwrapped in invokeMethod too.
 * If the exception is other Exception, it will not be unwrapped in the past.

In my experience, we needn't to unwrap the unknown exception.

 

> RBF: ProxyOpComplete is not accurate in FederationRPCPerformanceMonitor
> -----------------------------------------------------------------------
>
>                 Key: HDFS-14721
>                 URL: https://issues.apache.org/jira/browse/HDFS-14721
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: rbf
>            Reporter: xuzq
>            Assignee: xuzq
>            Priority: Major
>         Attachments: HDFS-14721-trunk-001.patch, HDFS-14721-trunk-002.patch
>
>
> ProxyOpComplete is not accurate in FederationRPCPerformanceMonitor when RemoteException
is returned.
> Because the remoteException is unwrap in invoke method, and it will be proxyOpComplete(false)
in invokeMethod.
> {code:java}
> // invoke method
> if (ioe instanceof RemoteException) {
>   RemoteException re = (RemoteException) ioe;
>   ioe = re.unwrapRemoteException();
>   ioe = getCleanException(ioe);
> }
> // invokeMethod method
> if (this.rpcMonitor != null) {
>   this.rpcMonitor.proxyOpFailureCommunicate();
>   this.rpcMonitor.proxyOpComplete(false);
> }
> throw ioe;{code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message